Skip to content

Conversation

@lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Feb 9, 2021

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for osdocs ready!

Built with commit 455ec3d

https://deploy-preview-29298--osdocs.netlify.app

@lpettyjo
Copy link
Contributor Author

lpettyjo commented Mar 9, 2021

Original requester has approved this change.

@xiuwang PTAL.

@xiuwang
Copy link

xiuwang commented Mar 10, 2021

@lpettyjo
LGTM

Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits; looks good otherwise!

@codyhoag codyhoag added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.8 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2021
@kalexand-rh kalexand-rh merged commit 63f2fec into openshift:master Mar 12, 2021
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.5

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #30402

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #30403

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #30404

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #30405

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants