Skip to content

Conversation

@johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Feb 9, 2021

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for osdocs ready!

Built with commit 1bff817

https://deploy-preview-29321--osdocs.netlify.app

Copy link

@iurygregory iurygregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ty!

@ahardin-rh ahardin-rh self-assigned this Feb 10, 2021
@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR telco Label for all Telco PRs labels Feb 10, 2021
@ahardin-rh ahardin-rh added this to the Future Release milestone Feb 10, 2021
@ahardin-rh
Copy link
Contributor

@iurygregory Is this work targeting 4.7 or 4.8? I notice that the associated JIRAs are for 4.8 so just want to confirm before merging. Thanks!

@iurygregory
Copy link

@ahardin-rh we need this documentation in 4.7, we will have code to verify the support for virtual media in 4.8. I think we will also need the information about firmware in 4.6 docs, because virtual media support was added in 4.6

@ahardin-rh
Copy link
Contributor

Thank you!

@ahardin-rh
Copy link
Contributor

@johnwilkins You might need to look into what content needs backported to 4.6 based off of Iury's comment above. I will get this in for 4.7. Than you, all!

@ahardin-rh ahardin-rh merged commit 75418cf into openshift:master Feb 10, 2021
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #29387

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnwilkins johnwilkins deleted the knideploy-2088 branch May 18, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants