Clarify when cleanup needs to be run#2954
Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom Sep 28, 2016
Merged
Conversation
Contributor
Author
|
@danwinship PTAL |
Contributor
|
I'd say something more like "if you are switching from an OpenShift plugin to a third-party plugin, then ..." |
There is no need to clean up several things when changing between variants of the OpenShift SDN plugin.
knobunc
force-pushed
the
fix/clarify-change-plugin
branch
from
dd0ab66 to
92c1c8e
Compare
Contributor
Author
|
Thanks @danwinship . Changed. |
Contributor
|
lgtm |
|
LGTM |
Contributor
|
Looks good to me. Thanks! |
Contributor
|
[rev_history] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to clean up several things when changing between
variants of the OpenShift SDN plugin.