Skip to content

Conversation

@codyhoag
Copy link
Contributor

Resolves #29541

@codyhoag codyhoag added this to the Next Release milestone Feb 17, 2021
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2021
@codyhoag
Copy link
Contributor Author

@jianlinliu can you verify? Thanks!

@netlify
Copy link

netlify bot commented Feb 17, 2021

Deploy preview for osdocs ready!

Built with commit a65e22c

https://deploy-preview-29552--osdocs.netlify.app

@jianlinliu
Copy link

LGTM.

@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 18, 2021
@mburke5678
Copy link
Contributor

@codyhoag LGTM.
I wonder, not being familiar with the install process, there are sections in some restricted install assemblies that seem to be UPI-specific: Completing installation on user-provisioned infrastructure, Creating the user-provisioned infrastructure. Do we need to expressly state in these sections that IPI folks don't need to do these steps or do the steps need to be modified for IPI?
Also, the issue states that _vSphere IPI_is supported for restricted. Do we need ifdef statements for vSphere only or is IPI supported for all platforms?

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 18, 2021
@codyhoag
Copy link
Contributor Author

@mburke5678 your points are all valid, and currently a pain point we're trying to address. Historically, UPI was the only way, so restricted networks were understood to be UPI. Recently, a capability emerged that allowed for IPI installs to install into a restricted network, but the docs have not been updated to reflect that yet (OSP being the exception). The IPI procedures will require new assemblies (most cloud providers support IPI restricted now). This is currently in the queue to work on.

In summary, this is a known issue. But I do think a good short term goal would be to at least update the restricted network titles to explicitly state they're for UPI, now that there are two possibilities. I'll follow up with some edits for that once the freeze is lifted. Thanks!

Copy link
Contributor

@vikram-redhat vikram-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for merge

@codyhoag
Copy link
Contributor Author

With pre-GA approval exception, I'm merging this.

@codyhoag codyhoag merged commit f5272a2 into openshift:master Feb 22, 2021
@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@codyhoag: #29552 failed to apply on top of branch "enterprise-4.7":

Applying: Restricted network installs are no longer UPI-only
Using index info to reconstruct a base tree...
M	modules/installation-about-restricted-network.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-about-restricted-network.adoc
CONFLICT (content): Merge conflict in modules/installation-about-restricted-network.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Restricted network installs are no longer UPI-only
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.6

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@codyhoag: #29552 failed to apply on top of branch "enterprise-4.6":

Applying: Restricted network installs are no longer UPI-only
Using index info to reconstruct a base tree...
M	modules/installation-about-restricted-network.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-about-restricted-network.adoc
CONFLICT (content): Merge conflict in modules/installation-about-restricted-network.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Restricted network installs are no longer UPI-only
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@codyhoag: #29552 failed to apply on top of branch "enterprise-4.5":

Applying: Restricted network installs are no longer UPI-only
Using index info to reconstruct a base tree...
M	modules/installation-about-restricted-network.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-about-restricted-network.adoc
CONFLICT (content): Merge conflict in modules/installation-about-restricted-network.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Restricted network installs are no longer UPI-only
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enterprise-4.6] Issue in file installing/installing_vsphere/installing-restricted-networks-vsphere.adoc

6 participants