Skip to content

Conversation

@mburke5678
Copy link
Contributor

The OpenShift Container Platform upgrade channels and releases topic has a hard-coded OCP version that needs to be manually updated to the next OCP version.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2021
@netlify
Copy link

netlify bot commented Mar 1, 2021

Deploy preview for osdocs ready!

Built with commit f1649ef

https://deploy-preview-29937--osdocs.netlify.app

@mburke5678 mburke5678 requested a review from codyhoag March 1, 2021 18:36
@mburke5678
Copy link
Contributor Author

@codyhoag PTAL. If this is right, should it go to master or 4.7?

@codyhoag
Copy link
Contributor

codyhoag commented Mar 1, 2021

@mburke5678 glad you caught this! You can take a look at this comment for some background. In summary, this version should always be the current OCP version+1. So master/enterprise-4.8 should be 4.9 and enterprise-4.7 should reflect 4.8.

IMO, I think removing the product-version attribute may be useful here, since this is easily missed. We could just make the following change and merge/CP to 4.7, 4.8, and master:

For instance, {product-title} 4.6 upgrade channels will never include an upgrade to a 4.7 release.

This would prevent us from constantly updating (and possibly missing this) every release. Or at least only force us to update the hard-coded versions every few releases, only when a version is EOL. 😅

@mburke5678 mburke5678 force-pushed the fix-version-upgrade-channel branch from a793e3c to f1649ef Compare March 1, 2021 21:58
@mburke5678
Copy link
Contributor Author

@codyhoag I removed the {product-version}, as you suggested. PTAL

For instance, {product-title} 4.7 upgrade channels will never include an upgrade to a 4.8 release.

Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mburke5678 mburke5678 merged commit 1f24689 into openshift:master Mar 2, 2021
@mburke5678 mburke5678 deleted the fix-version-upgrade-channel branch March 2, 2021 14:33
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@mburke5678: new pull request created: #29979

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #29980

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants