-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Changed to in Update Channels section of upgrade docs #29937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to in Update Channels section of upgrade docs #29937
Conversation
|
Deploy preview for osdocs ready! Built with commit f1649ef |
|
@codyhoag PTAL. If this is right, should it go to |
|
@mburke5678 glad you caught this! You can take a look at this comment for some background. In summary, this version should always be the current OCP version+1. So IMO, I think removing the
This would prevent us from constantly updating (and possibly missing this) every release. Or at least only force us to update the hard-coded versions every few releases, only when a version is EOL. 😅 |
a793e3c to
f1649ef
Compare
|
@codyhoag I removed the {product-version}, as you suggested. PTAL
|
codyhoag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/cherrypick enterprise-4.7 |
|
@mburke5678: new pull request created: #29979 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.8 |
|
@mburke5678: new pull request created: #29980 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The OpenShift Container Platform upgrade channels and releases topic has a hard-coded OCP version that needs to be manually updated to the next OCP version.