The DHCP shim configuration should include type: Raw #30167
Conversation
…tion for yaml block style This adds the `type: Raw` field, as well as indents the curly braces.
openshift-ci-robot
added
the
size/S
|
/assign @mikemckiernan |
|
Deploy preview for osdocs ready! Built with commit bfe74e2 |
|
Doug's update is to the code block at https://deploy-preview-30167--osdocs.netlify.app/openshift-enterprise/latest/networking/multiple_networks/configuring-bridge.html#nw-multus-dhcp_configuring-bridge Applies to 4.8 through 4.5. Please add milestone Next-Release. @openshift/team-documentation PTAL. |
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
This LGTM, but it still needs QE approval before we can merge it.
kalexand-rh
added
the
peer-review-done
|
/assign @weliang1 Weibin, the team tracking XLS has you listed as the QE contact for Multus. If you are not the correct QE contact, can you reassign it? Thank you. |
|
@dougbtv thanks for this! |
s1061123
left a comment
s1061123
left a comment
There was a problem hiding this comment.
It looks good to me, too! Thanks!
|
/LGMT |
|
Reviews complete - merging + cherry picking. :) |
|
/cherrypick enterprise-4.5 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.8 |
|
@bmcelvee: new pull request created: #30525 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bmcelvee: new pull request created: #30526 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bmcelvee: new pull request created: #30527 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bmcelvee: new pull request created: #30528 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 participants
This adds the
type: Rawfield, as well as indents the curly braces.