Skip to content

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Mar 10, 2021

RH supplementary style guide says that the [CAUTION] admonition block type should not be used. Adjusting the few we had in use to other supported types that seem appropriate.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2021
@adellape adellape changed the title Change [CAUTION] admonitions to [IMPORTANT] Change [CAUTION] admonitions to supported types Mar 10, 2021
@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for osdocs ready!

Built with commit 9137fdd

https://deploy-preview-30315--osdocs.netlify.app

====
+
[CAUTION]
[WARNING]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwelldb FYI on the adjustment here from #25509. Matching the "WARNING" adjustment from #25511 for the similar note in https://github.com/openshift/openshift-docs/blame/master/modules/installation-osp-creating-image.adoc#L54.

Although it is not recommended, you can override this functionality and install {product-title} without verifying a certificate by installing {product-title} on {rh-virtualization} in *insecure* mode.

[CAUTION]
[WARNING]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stoobie FYI on the adjustment here from #28717.

@openshift openshift deleted a comment from netlify bot Mar 10, 2021
@adellape adellape added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.7 branch/enterprise-4.8 labels Mar 10, 2021
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codyhoag codyhoag added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 10, 2021
@adellape adellape merged commit b2b3e86 into openshift:master Mar 10, 2021
@adellape adellape deleted the rm_caution branch March 10, 2021 18:45
@adellape
Copy link
Contributor Author

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@adellape: new pull request created: #30318

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@adellape: new pull request created: #30319

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants