-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Change [CAUTION] admonitions to supported types #30315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for osdocs ready! Built with commit 9137fdd |
| ==== | ||
| + | ||
| [CAUTION] | ||
| [WARNING] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxwelldb FYI on the adjustment here from #25509. Matching the "WARNING" adjustment from #25511 for the similar note in https://github.com/openshift/openshift-docs/blame/master/modules/installation-osp-creating-image.adoc#L54.
| Although it is not recommended, you can override this functionality and install {product-title} without verifying a certificate by installing {product-title} on {rh-virtualization} in *insecure* mode. | ||
|
|
||
| [CAUTION] | ||
| [WARNING] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codyhoag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/cherrypick enterprise-4.7 |
|
@adellape: new pull request created: #30318 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.8 |
|
@adellape: new pull request created: #30319 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
RH supplementary style guide says that the
[CAUTION]admonition block type should not be used. Adjusting the few we had in use to other supported types that seem appropriate.