Skip to content

Bug 1850495 Tolerations shouldn't be defined in rsyslog but in fluentd #30439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
Mar 16, 2021
Merged

Bug 1850495 Tolerations shouldn't be defined in rsyslog but in fluentd #30439

codyhoag merged 1 commit into from
Mar 16, 2021

Conversation

@rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Mar 15, 2021 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2021
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 15, 2021 •
edited
Loading

@xltian Please review and approve. Thanks.

@netlify
Copy link

netlify bot commented Mar 15, 2021

Deploy preview for osdocs ready!

Built with commit d7b4fa5

https://deploy-preview-30439--osdocs.netlify.app

@xltian
Copy link

xltian commented Mar 15, 2021

@anpingli from OpenShift QE will review

anpingli
anpingli reviewed Mar 16, 2021
View reviewed changes
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@codyhoag codyhoag added this to the Next Release milestone Mar 16, 2021
codyhoag
codyhoag approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codyhoag codyhoag merged commit d8cfb1d into openshift:master Mar 16, 2021
@codyhoag
Copy link
Contributor

codyhoag commented Mar 16, 2021

/cherrypick enterprise-4.8

@codyhoag
Copy link
Contributor

codyhoag commented Mar 16, 2021

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor

codyhoag commented Mar 16, 2021

/cherrypick enterprise-4.6

@codyhoag
Copy link
Contributor

codyhoag commented Mar 16, 2021

/cherrypick enterprise-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 16, 2021

@codyhoag: new pull request created: #30516

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 16, 2021

@codyhoag: new pull request created: #30517

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 16, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 16, 2021

@codyhoag: new pull request created: #30518

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 16, 2021

@codyhoag: new pull request created: #30519

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag codyhoag added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 16, 2021
@rolfedh rolfedh deleted the bz#1850495 branch March 17, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@anpingli anpingli anpingli left review comments

@codyhoag codyhoag codyhoag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anpingli anpingli

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@rolfedh @xltian @codyhoag @openshift-cherrypick-robot @anpingli @openshift-ci-robot