Skip to content

GH#30569 Azure private clarification #30590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
Mar 19, 2021
Merged

GH#30569 Azure private clarification #30590

codyhoag merged 1 commit into from
Mar 19, 2021

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Mar 17, 2021 •
edited
Loading

@codyhoag codyhoag added this to the Next Release milestone Mar 17, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2021
@codyhoag codyhoag changed the title Azure private clarification GH#30569 Azure private clarification Mar 17, 2021
@netlify
Copy link

netlify bot commented Mar 17, 2021

Deploy preview for osdocs ready!

Built with commit 6613aac

https://deploy-preview-30590--osdocs.netlify.app

@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 17, 2021

@mgahagan73 PTAL

@mgahagan73
Copy link

mgahagan73 commented Mar 18, 2021

I reviewed the Divsion of Permissions section paragraph and the permissions description looks good as well as the warning about clusters sharing vnets

LGTM

@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 19, 2021
@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 19, 2021
@bmcelvee
Copy link
Contributor

bmcelvee commented Mar 19, 2021

LGTM!

@codyhoag codyhoag merged commit b943880 into openshift:master Mar 19, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 19, 2021

/cherrypick enterprise-4.8

@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 19, 2021

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 19, 2021

/cherrypick enterprise-4.6

@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 19, 2021

/cherrypick enterprise-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 19, 2021

@codyhoag: new pull request created: #30686

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 19, 2021

@codyhoag: new pull request created: #30687

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 19, 2021

@codyhoag: new pull request created: #30688

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 19, 2021

@codyhoag: new pull request created: #30689

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2021
Merged
This was referenced Mar 23, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

[enterprise-4.6] Issue in file installing/installing_azure/installing-azure-private.adoc

5 participants

@codyhoag @mgahagan73 @bmcelvee @openshift-cherrypick-robot @openshift-ci-robot