Fix TOC issue #30712
Fix TOC issue #30712
Conversation
openshift-ci-robot
added
the
size/XXL
|
Deploy preview for osdocs ready! Built with commit 25b3e50 |
vikram-redhat
added
the
okd-only
There was a problem hiding this comment.
Some of the assemblies now have two preceding blank lines. Is it worth only adding blank lines to the assemblies that do not currently have one between the header and the toc declaration, for consistency?
There was a problem hiding this comment.
Yep, I've noticed this for the couple of serverless ones I've looked at so far also
There was a problem hiding this comment.
I am trying to script a solution for this.
There was a problem hiding this comment.
I have now run a script against a local clone of this PR and then pushed the changes to the original commit. There should now be one blank line preceding the toc::[] line in each assembly file.
JStickler
left a comment
JStickler
left a comment
There was a problem hiding this comment.
ACK from service mesh team. Just let us know when it merges so we make sure we rebase our PRs (we don't want to overwrite this accidentally!).
|
LGTM! |
| include::modules/authentication-api-impersonation.adoc[leveloffset=+1] | ||
|
|
||
| include::modules/impersonation-project-creation.adoc[leveloffset=+1] | ||
| include::modules/impersonation-project-creation.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Where you see the last line in a file being removed and added in this PR, this is the TOC blank line correction script adding new lines to the end of a file where one did not previously exist. It was a side effect of the script, but it is useful.
|
LGTM. |
|
Verified for odo, ODC, Helm, Build, Pipelines, GitOps, Logging. LGTM. Thank you @pneedle-rh and @vikram-redhat |
|
@pneedle-rh I am going to merge this. Please merge the rest of the release branch PRs. |
8 participants
This PR:
A separate PR will need to be created for each release branch.