Skip to content

GitHub-26681: Noted new flag for JDK 11+ #30784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergerhoffer merged 1 commit into from
May 10, 2021
Merged

GitHub-26681: Noted new flag for JDK 11+ #30784

bergerhoffer merged 1 commit into from
May 10, 2021

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 23, 2021 •
edited
Loading

@bergerhoffer bergerhoffer added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 issue-burndown Indicates an issue worked on during an "GitHub Issue Burndown" session labels Mar 23, 2021
@bergerhoffer bergerhoffer added this to the Next Release milestone Mar 23, 2021
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 23, 2021
@bergerhoffer bergerhoffer mentioned this pull request Mar 23, 2021
Closed
@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for osdocs ready!

Built with commit ef24ddd

https://deploy-preview-30784--osdocs.netlify.app

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 23, 2021
@bmcelvee
Copy link
Contributor

bmcelvee commented Mar 23, 2021

LGTM!

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Apr 12, 2021

@sunilcio Can you please QE review this? Or let me know if there is someone else that I should ask? Thanks!

Preview: https://deploy-preview-30784--osdocs.netlify.app/openshift-enterprise/latest/nodes/clusters/nodes-cluster-resource-configure.html#nodes-cluster-resource-configure-jdk-heap_nodes-cluster-resource-configure

@sunilcio
Copy link

sunilcio commented Apr 29, 2021

@bergerhoffer missed this one earlier. It looks this would require review from OpenJDK team. @wsun1 do you know who can help review this one?

@sunilcio
Copy link

sunilcio commented May 7, 2021

Okay, after reviewing below links, this LGTM.
https://access.redhat.com/solutions/4564491
https://www.eclipse.org/openj9/docs/xxusecontainersupport
https://bugs.openjdk.java.net/browse/JDK-8250627

@bergerhoffer bergerhoffer merged commit 3c91b8a into openshift:master May 10, 2021
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented May 10, 2021

/cherrypick enterprise-4.8

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented May 10, 2021

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented May 10, 2021

/cherrypick enterprise-4.6

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented May 10, 2021

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 10, 2021

@bergerhoffer: new pull request created: #32378

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 10, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 10, 2021

@bergerhoffer: new pull request created: #32379

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 10, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 10, 2021

@bergerhoffer: new pull request created: #32380

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 10, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 10, 2021

@bergerhoffer: new pull request created: #32381

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer deleted the github-26681 branch August 3, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 issue-burndown Indicates an issue worked on during an "GitHub Issue Burndown" session peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

memory settings for jdk11+ on openshift

5 participants

@bergerhoffer @bmcelvee @sunilcio @openshift-cherrypick-robot @openshift-ci-robot