-
Notifications
You must be signed in to change notification settings - Fork 1.8k
BZ1852798: Removed etcd instructions #30950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 0a0e3ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61016d0da5ac1c0008b758f8 😎 Browse the preview: https://deploy-preview-30950--osdocs.netlify.app |
|
@pamoedom - Please review the row removal from the table and let me know if this looks good to you per the BZ. |
|
LGTM - I only applied labels back to 4.5, which is the oldest supported OCP release currently. |
|
Hi @sagidlow, the modification LGTM, however, I think we need to remove more things from the documentation, for example, look at the Cloudformation template here: Let me make an AWS-UPI build with those cloudformation templates to confirm exactly all the lines to remove from the control planes template. I'll keep you posted. |
|
Hi again @sagidlow, I have successfully installed OCP 4.7.3 on top of AWS UPI using the following cloudformation template: Here you have the diff output, which is more easy to see: But there is one problem I see here, that our templates are based on the official ones provided by Engineering here, so IMO, in order to change this in the documentation, we should raise first an issue/PR with them to confirm, please hold on to the changes for the moment, thanks. |
|
Raised PR#4795 for installer team, let's see if they confirm my changes or suggest any modification. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
Hi @sagidlow, we have news about this modification, new changes have been finally pushed to 4.11 via openshift/installer#5764 for the 05_cluster_master_nodes.yaml cloudformation template, please take a look when you have a moment, thanks. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Only versions 4.8+ are still in maintenance. I am removing labels from earlier versions from this PR. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Applies to 4.4+
BZ Link: https://bugzilla.redhat.com/show_bug.cgi?id=1852798
QE Approval Needed: @pamoedom
Preview Link: https://deploy-preview-30950--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-user-infra.html#installation-aws-user-infra-other-infrastructure_installing-aws-user-infra (Required DNS and load balancing components table)