Skip to content

Comments

document build nodeselector and annotation configuration#3097

Merged
bfallonf merged 1 commit intoopenshift:masterfrom
bparees:build_nodes
Oct 26, 2016
Merged

document build nodeselector and annotation configuration#3097
bfallonf merged 1 commit intoopenshift:masterfrom
bparees:build_nodes

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Oct 24, 2016

No description provided.

@bparees
Copy link
Contributor Author

bparees commented Oct 24, 2016

@openshift/team-documentation ptal/merge.

@vikram-redhat
Copy link
Contributor

@bfallonf - PTAL.

@bfallonf
Copy link

@bparees This looks largely pretty great. Big thanks.

There is a bit of overlap between what's here and what's in the Deployment section though:
https://docs.openshift.com/container-platform/3.3/dev_guide/deployments.html#assigning-pods-to-specific-nodes

It's sorta the same process, but with deployments switched with builds. Is that really the only difference? I might be able to play with some of the context info so we're not repeating ourselves...

Other than that, thanks, again!

@bparees
Copy link
Contributor Author

bparees commented Oct 25, 2016

@bfallonf yes it's basically the same concepts. If you can find a way to refactor the content to a common location and then reference it from both sections that would be fine.

but it's important to have an actual example of how to define a nodeselector within a buildconfig, so you can't refactor too much of it out.

@bfallonf
Copy link

@bparees Sure thing. Thanks. I'll leave it as suggested for now, but it might be something I think about for the future. And you're correct that an example for both is a good idea.

Thanks again. I'll merge.

@bfallonf bfallonf added this to the Future Release milestone Oct 26, 2016
@bfallonf bfallonf merged commit 2caf962 into openshift:master Oct 26, 2016
@bfallonf bfallonf mentioned this pull request Oct 26, 2016
@bparees bparees deleted the build_nodes branch November 2, 2016 19:46
@ahardin-rh
Copy link
Contributor

Rev history in follow-up PR

@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.4 GA Jan 16, 2017
@adellape adellape modified the milestones: OCP 3.4 GA, Staging, Temp Feb 1, 2017
@adellape adellape modified the milestones: Temp, Staging, OCP 3.4 GA Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants