Skip to content

[srvls] [SRVOCF-264] Add tech preview functions docs #31878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
May 4, 2021
Merged

[srvls] [SRVOCF-264] Add tech preview functions docs #31878

codyhoag merged 1 commit into from
May 4, 2021

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Apr 23, 2021 •
edited
Loading

Changes:

  • Added Functions section to topicmap, functions dir, new product attributes in serverless attributes file
  • Functions setup, overview docs
  • Added kn commands for create, build and deploying functions

Note: can be merged but new docs should be commented out for tech preview. 4.6+

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2021
@netlify
Copy link

netlify bot commented Apr 23, 2021

Deploy preview for osdocs ready!

Built with commit 1cb6aed2ed7f61c923c7819bd294c2bab02369bc

https://deploy-preview-31878--osdocs.netlify.app

@netlify
Copy link

netlify bot commented Apr 23, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 0bfa183

https://deploy-preview-31878--osdocs.netlify.app

@abrennan89 abrennan89 force-pushed the SRVOCF-278 branch 3 times, most recently from a1f85cf to 88b3bf6 Compare April 26, 2021 19:21
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2021
@abrennan89 abrennan89 changed the title [WIP] [srvls] [SRVOCF-264] Add tech preview functions docs [srvls] [SRVOCF-264] Add tech preview functions docs Apr 26, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2021
jrangelramos
jrangelramos reviewed Apr 28, 2021
View reviewed changes
@jrangelramos
Copy link
Contributor

jrangelramos commented May 3, 2021

QE Approved :)

@codyhoag codyhoag self-requested a review May 3, 2021 14:32
codyhoag
codyhoag reviewed May 3, 2021
View reviewed changes
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Just a few suggestions

@abrennan89 abrennan89 force-pushed the SRVOCF-278 branch 2 times, most recently from 10236bf to bd637a3 Compare May 3, 2021 20:08
@codyhoag codyhoag added this to the Next Release milestone May 4, 2021
codyhoag
codyhoag reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit; then all looks good!

@codyhoag codyhoag self-requested a review May 4, 2021 14:00
codyhoag
codyhoag approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codyhoag codyhoag merged commit 1ab5989 into openshift:master May 4, 2021
@codyhoag
Copy link
Contributor

codyhoag commented May 4, 2021

/cherrypick enterprise-4.8

@codyhoag
Copy link
Contributor

codyhoag commented May 4, 2021

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor

codyhoag commented May 4, 2021

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 4, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 4, 2021

@codyhoag: new pull request created: #32171

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 4, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 4, 2021

@codyhoag: new pull request created: #32172

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 4, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 4, 2021

@codyhoag: new pull request created: #32173

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag codyhoag added the serverless Label for all Serverless PRs label May 4, 2021
@abrennan89 abrennan89 deleted the SRVOCF-278 branch December 17, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@lance lance lance left review comments

@mgencur mgencur mgencur left review comments

@jrangelramos jrangelramos jrangelramos left review comments

@codyhoag codyhoag codyhoag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@abrennan89 @jrangelramos @codyhoag @openshift-cherrypick-robot @lance @mgencur @openshift-ci-robot