-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update ignition spec version on the MachineConfig examples #32038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 883489e 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dfbe14ab3d940009dfed86 😎 Browse the preview: https://deploy-preview-32038--osdocs.netlify.app |
|
@ahardin-rh PTAL |
|
@ahardin-rh Any update? Thanks. |
70e00ee to
5bf4834
Compare
|
Solved the conflict files and updated other files which have the same issue. @ahardin-rh Could you have a look at this PR when available? Thanks. |
5bf4834 to
883489e
Compare
|
@vikram-redhat Could you re-assign someone to review this PR? Because previous assigner not response almost 3 months so far, thanks. |
|
@lbscorpio So sorry for the delay! I have no idea how I missed this. This looks good. Thank you! |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.8 |
|
@ahardin-rh: #32038 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahardin-rh: new pull request created: #34823 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vikram-redhat There are two issues on the examples of machineconfig, minimum version that the change applies to should be 4.7 in my opinion, could you arrange someone to review them? Thanks.
post_installation_configuration/machine-configuration-tasks.adoc
The ignition version should be 3.2.0 for OCP 4.7, except 99-master-ssh and 99-worker-ssh which should be 3.1.0. Provided the real outputs on an OCP 4.7.3 environment as below:
installing/installing_vmc/modules/installation-disk-partitioning.adoc