Skip to content

Comments

Bug 1384746 added section on tuning sysctl values#3242

Merged
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:haproxy_1384746
Nov 30, 2016
Merged

Bug 1384746 added section on tuning sysctl values#3242
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:haproxy_1384746

Conversation

@bfallonf
Copy link

As per: https://bugzilla.redhat.com/show_bug.cgi?id=1384746

@jeremyeder @jmencak @ahardin-rh as per email.

I changed around some of the wording. Any thoughts?

@jmencak
Copy link
Contributor

jmencak commented Nov 17, 2016

Rewording seems good to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh
Copy link
Contributor

Just one comment. Otherwise, LGTM. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/In clusters, t/T

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this issue occurs, you may begin to see the oc client commands being to fail with the following error:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/recommended/suggested for clusters with large numbers of routes.

Note: we should state which machine this needs to be run on...nodes running router pods only, right? So, most likely the infra nodes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, I've seen nodes running router pods affected with this only. So, perhaps something like this?

The following sysctl values are suggested for clusters with large numbers of routes on infra nodes running router pods:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a sentence on running it on the router pods. There's a chance it won't be on the infra nodes, but if so, it'll be easier to find.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove now duplicate lines 1371-1373.

@bfallonf
Copy link
Author

@jmencak Thanks for that. Mistake on my part.

@adellape @ahardin-rh @gaurav-nelson peer review please?

@bfallonf
Copy link
Author

[rev_history]
|xref:../install_config/router/default_haproxy_router.adoc#install-config-router-default-haproxy[Setting up a Router -> Using the Default HAProxy Router]
|Added the xref:../install_config/router/default_haproxy_router.adoc#deploy-router--arp-cach-tuning-for-large-scale-clusters[ARP Cache Tuning for Large-scale Clusters] section.
%

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra - here (router--arp-cach)

@ahardin-rh
Copy link
Contributor

Just 2 minor comments. Otherwise, LGTM.

@bfallonf
Copy link
Author

Thanks @ahardin-rh . I'll merge away.

@bfallonf bfallonf merged commit 70602f7 into openshift:master Nov 30, 2016
@bfallonf bfallonf deleted the haproxy_1384746 branch November 30, 2016 05:30
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.4 GA Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants