Skip to content

Conversation

@mgarrell777
Copy link
Contributor

@mgarrell777 mgarrell777 commented May 12, 2021

This PR covers Jira story CNV-6967 ( https://issues.redhat.com/browse/CNV-6967 ).

The story deals with the new support for cloning VMs from a Filesystem volume to a Block volume and vice-versa. Changes made indicate the new support, while cautioning that such cloning can only be done if the volumes are of the kubevirt content-type. The changes have been made to Warnings at the start of 3 sections pertaining to cloning virtual machines.

CP: 4.8

Preview:

https://deploy-preview-32471--osdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/cloning_vms/virt-cloning-vm-disk-into-new-datavolume.html

https://deploy-preview-32471--osdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/cloning_vms/virt-cloning-vm-using-datavolumetemplate.html

https://deploy-preview-32471--osdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/cloning_vms/virt-cloning-vm-disk-into-new-datavolume-block.html

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2021
@netlify
Copy link

netlify bot commented May 12, 2021

Deploy Preview for osdocs ready!

Built with commit f335622

https://deploy-preview-32471--osdocs.netlify.app

@awels
Copy link

awels commented May 12, 2021

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

@awels: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dalia-frank
Copy link

lgtm

Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, but there are a couple of comments that apply to all three files. You might want to double check with dev or QE on the new phrasing/formatting. Thanks, Matthew!

…ferent persistent volume modes is supported with certain limits

JIRA CNV-6967 Updating based on peer review
@ousleyp ousleyp added branch/enterprise-4.8 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR labels May 20, 2021
@ousleyp ousleyp added this to the Future Release milestone May 20, 2021
@ousleyp ousleyp merged commit ae84bcd into openshift:master May 20, 2021
@ousleyp
Copy link
Member

ousleyp commented May 20, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@ousleyp: new pull request created: #32685

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants