Skip to content

OSDOCS-1266 Remove grafana and alertmanager ui links and info #32587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbarbeevargas merged 1 commit into from
Jun 22, 2021
Merged

OSDOCS-1266 Remove grafana and alertmanager ui links and info #32587

lbarbeevargas merged 1 commit into from
Jun 22, 2021

Conversation

@lbarbeevargas
Copy link
Contributor

@lbarbeevargas lbarbeevargas commented May 17, 2021 •
edited
Loading

https://issues.redhat.com/browse/OSDOCS-1266 for https://issues.redhat.com/browse/MON-1278

  • Updates monitoring dashboard screenshots with screenshots that do not include the Grafana and Alertmanager UI links.
  • Adds option to input/select a custom time range for a dashboard as an admin or developer.

Previews:

@lbarbeevargas lbarbeevargas added this to the Future Release milestone May 17, 2021
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2021
@netlify
Copy link

netlify bot commented May 17, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 9c397bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d220ba950d5e000841527e

😎 Browse the preview: https://deploy-preview-32587--osdocs.netlify.app/openshift-enterprise/latest/installing/validating-an-installation

@lbarbeevargas lbarbeevargas force-pushed the OSDOCS-1266-remove-grafana-alertmanager-ui-links-4-8 branch 5 times, most recently from a81ac6c to 25182c7 Compare May 20, 2021 20:30
@lbarbeevargas lbarbeevargas force-pushed the OSDOCS-1266-remove-grafana-alertmanager-ui-links-4-8 branch 3 times, most recently from 0582d84 to 237999d Compare June 7, 2021 13:32
lbarbeevargas
lbarbeevargas commented Jun 7, 2021
View reviewed changes
monitoring/accessing-third-party-uis.adoc Outdated
Copy link
Contributor Author

@lbarbeevargas lbarbeevargas Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I combined these two notes so that we don't have back-to-back notes here. We try to avoid that in the docs if possible.

@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 7, 2021

@kyoto @sichvoge @lihongyan1 PTAL for 4.8 updates. Thank you!

kyoto
kyoto reviewed Jun 9, 2021
View reviewed changes
monitoring/accessing-third-party-uis.adoc Outdated
Copy link
Member

@kyoto kyoto Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{product-title} also provides access to the Prometheus, Alertmanager, and Grafana third-party interfaces. Additional platform components are included in *Monitoring* → *Dashboards* in the {product-title} web console.
{product-title} also provides access to the Prometheus, Alertmanager, and Grafana third-party interfaces. Dashboards for some additional platform components are included in *Monitoring* → *Dashboards* in the {product-title} web console.

Copy link
Member

@kyoto kyoto Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or something similar to clarify that the only additional thing on that page is some more dashboards.

@lbarbeevargas lbarbeevargas force-pushed the OSDOCS-1266-remove-grafana-alertmanager-ui-links-4-8 branch from 237999d to f126009 Compare June 10, 2021 20:01
@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 10, 2021

@lihongyan1 PTAL, thank you.

@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 16, 2021

@lihongyan1 @juzhao PTAL for 4.8 feature work. Thank you!

@lihongyan1
Copy link

lihongyan1 commented Jun 17, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
@kyoto
Copy link
Member

kyoto commented Jun 17, 2021

LGTM

@lbarbeevargas lbarbeevargas added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 17, 2021
mburke5678
mburke5678 reviewed Jun 21, 2021
View reviewed changes
modules/monitoring-reviewing-monitoring-dashboards-admin.adoc Outdated
Copy link
Contributor

@mburke5678 mburke5678 Jun 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step calls it the Time Range dropdown. Previous step uses Time Range list. Not sure which is right, but should be consistent.

@mburke5678
Copy link
Contributor

mburke5678 commented Jun 21, 2021

@lbarbeevargas I wonder if the time range steps should be in an unordered list, as you can't do both?

. Optional: Select a time range for the graphs in the Time Range list.
.. Select a pre-defined time period.
.. Set a custom time period by...

If not, LGTM.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 21, 2021
@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 21, 2021

@mburke5678 Good idea to make this into an unordered list. 👍

@lbarbeevargas lbarbeevargas force-pushed the OSDOCS-1266-remove-grafana-alertmanager-ui-links-4-8 branch from f126009 to 0d3dac6 Compare June 21, 2021 19:36
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 21, 2021

@kyoto @lihongyan1
Per the peer review, I made some small procedure updates to setting a custom time range for dashboard graphs. Please take a final look at modules/monitoring-reviewing-monitoring-dashboards-admin.adoc and modules/monitoring-reviewing-monitoring-dashboards-developer.adoc. Thank you!

@kyoto
Copy link
Member

kyoto commented Jun 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@lihongyan1
Copy link

lihongyan1 commented Jun 22, 2021

lgtm

@lbarbeevargas lbarbeevargas force-pushed the OSDOCS-1266-remove-grafana-alertmanager-ui-links-4-8 branch from 0d3dac6 to 4647fe2 Compare June 22, 2021 17:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2021

New changes are detected. LGTM label has been removed.

@lbarbeevargas lbarbeevargas force-pushed the OSDOCS-1266-remove-grafana-alertmanager-ui-links-4-8 branch from 4647fe2 to 9c397bb Compare June 22, 2021 17:41
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2021
@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 22, 2021 •
edited
Loading

@kyoto @lihongyan1 @mburke5678
FYI: I was looking over the changes I made one last time for this PR before merging and realized that the modules/checking-cluster-resource-availability-and-utilization.adoc module in the install book needed the same Custom time range procedure update that I added in two other monitoring modules. I made identical updates to this module as were made for modules/monitoring-reviewing-monitoring-dashboards-admin.adoc and modules/monitoring-reviewing-monitoring-dashboards-developer.adoc.

@lbarbeevargas lbarbeevargas merged commit dfa863d into openshift:master Jun 22, 2021
@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Jun 22, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 22, 2021

@lbarbeevargas: new pull request created: #33779

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

+1 more reviewer

@kyoto kyoto kyoto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kyoto kyoto

@lihongyan1 lihongyan1

Labels

branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.8 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@lbarbeevargas @lihongyan1 @kyoto @mburke5678 @openshift-cherrypick-robot @vikram-redhat