-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[enterprise-4.7] Add Bug fix prefix on the logging release notes #32725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy Preview for osdocs ready! Built with commit 5733e4e |
rolfedh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@Preeticp Any update? Thanks. |
|
Hi, @lbscorpio. I've asked for someone to merge this PR. Thanks. |
|
/cherry-pick enterprise-4.7 |
|
@lbscorpio If this also needs to be in the 4.8 branch, ping me and I'll cherry pick to 4.8 as well. |
|
@JStickler: new pull request created: #34154 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JStickler Yes, it should cherry pick to 4.8 too, thanks. |
@JStickler There's no need to CP this to 4.8. I already have these changes in my work on the 5.1 Release Notes. I'd rather not have to perform a rebase. |
|
@rolfedh as long as the files get into 4.8, I don't care how they get there, Thanks for the info. |
|
/cherry-pick enterprise-4.8 |
|
@JStickler: #32725 failed to apply on top of branch "enterprise-4.8": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
D'oh, I forgot that Rolf had this covered. Not going to worry about the failed CP then. |
|
@JStickler. Please close this PR. Thanks. |
@vikram-redhat There is one minor issue on logging release notes, minimum version that the change applies to should be 4.7 in my opinion, could you arrange someone to review them? Thanks.