Conversation
|
honestly, I'd put it in the admin guide, and maybe make a note in the dev guide |
There was a problem hiding this comment.
this line reads a bit strangely, IMO.
There was a problem hiding this comment.
I'd say "you can idle applications fronted by services" (since the oc idle command takes in service names, but the idling action involves the whole "application" (service + dc/rc))
There was a problem hiding this comment.
In general, I'd probably call this "Idling Applications" (see comment below).
There was a problem hiding this comment.
While this is true, it's more of "this is useful for bulk-idling applications as part of a script"
There was a problem hiding this comment.
... state. This works with both traffic going through services, as well as traffic passed through routes, when using the HAProxy router in it's default configuration. Other routers will need to be configured to pass traffic through the service when they detect idling if they wish to unidle applications.
bfallonf
force-pushed
the
idling_1390467
branch
from
b0576ba to
026904e
Compare
|
@DirectXMan12 Thanks for the look-over. I switched it to the Adming Guide, but thought about where there could be a note in the Dev Guide, but came up short. I don't think the use case we're talking about here really fits into that. I made the rest of your suggestions though. I think it's explaining the process better. Can I get a final ack that I haven't got any of the info wrong though? Thanks again. |
DirectXMan12
left a comment
DirectXMan12
left a comment
There was a problem hiding this comment.
a couple of small comments. Otherwise, this looks good.
admin_guide/idling_applications.adoc
Outdated
There was a problem hiding this comment.
is this supposed to say admin-guide-idling-applications?
admin_guide/idling_applications.adoc
Outdated
There was a problem hiding this comment.
"as well as scalable resources" (services themselves are also a type of resource ;-) )
admin_guide/idling_applications.adoc
Outdated
There was a problem hiding this comment.
"marks it as idled, scaling down" (remove the "by", since we don't want to give the impression that just scaling down a resource will mark it as idled)
bfallonf
force-pushed
the
idling_1390467
branch
from
026904e to
5d1ba9a
Compare
|
@DirectXMan12 Thanks for the review again. If there's nothing else, I'll move this along. @gaurav-nelson @ahardin-rh @adellape Peer review plz? |
|
[rev_history] |
|
LGTM 👍 |
admin_guide/idling_applications.adoc
Outdated
There was a problem hiding this comment.
S/accosiated/associated
admin_guide/idling_applications.adoc
Outdated
There was a problem hiding this comment.
We can change 'as well as' to 'and' because of preceding 'both'.
|
minor changes. Rest is all good! 👍 |
bfallonf
force-pushed
the
idling_1390467
branch
from
5d1ba9a to
f7b97d2
Compare
|
Thanks! I'll merge this. |
| File: diagnostics_tool | ||
| Distros: openshift-origin,openshift-enterprise | ||
| - Name: Idling Applications | ||
| File: idling_applications.adoc |
There was a problem hiding this comment.
@bfallonf Just noticed the File has an .adoc on the end here. Looks like this is building in asciidoctor but not sure how it will fare with Portal.
There was a problem hiding this comment.
OK, yea, Portal build immediately failed. Gonna fix this real quick.
5 participants
As per: https://bugzilla.redhat.com/show_bug.cgi?id=1390467
Added a new "Idling and unidling" file to the dev guide.
@DirectXMan12 would you agree that the developer guide is the correct audience? It does sounds like something the admin would be doing, but it's using the "oc" command.
Also, if there's anything that's incorrect in the PR, please let me know.