Skip to content

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Jun 15, 2021

https://issues.redhat.com/browse/OSDOCS-1931

  • Breaks up modules/osdk-bundle-deploy-olm.adoc into separate modules/osdk-bundle-operator.adoc and modules/osdk-deploy-olm.adoc to make better logical room for...
  • ... a new modules/osdk-publish-catalog.adoc to show catalog-build and catalog-push usage (only added to the operators/operator_sdk/osdk-working-bundle-images.adoc assembly)

Preview:

@adellape adellape added this to the Future Release milestone Jun 15, 2021
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2021
@adellape adellape changed the title Add catalog-build / catalog-push to OSDK docs [WIP] Add catalog-build / catalog-push to OSDK docs Jun 15, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2021
@netlify
Copy link

netlify bot commented Jun 15, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 1c16fee

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d3a6dc0182e80007a87d93

😎 Browse the preview: https://deploy-preview-33483--osdocs.netlify.app

@adellape adellape force-pushed the catalog-build-push branch from 2f94ad2 to 7f0335a Compare June 15, 2021 22:19
@vikram-redhat vikram-redhat changed the title [WIP] Add catalog-build / catalog-push to OSDK docs [WIP] OSDOCS-1931: Add catalog-build / catalog-push to OSDK docs Jun 16, 2021
@adellape adellape force-pushed the catalog-build-push branch 2 times, most recently from 37c361c to 46344d8 Compare June 16, 2021 15:58
@adellape adellape changed the title [WIP] OSDOCS-1931: Add catalog-build / catalog-push to OSDK docs OSDOCS-1931: Add catalog-build / catalog-push to OSDK docs Jun 16, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 16, 2021
@adellape adellape force-pushed the catalog-build-push branch 6 times, most recently from c8da480 to 1e7f424 Compare June 16, 2021 21:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@adellape adellape force-pushed the catalog-build-push branch 10 times, most recently from 2b149fa to 32f684b Compare June 16, 2021 22:21
@adellape adellape force-pushed the catalog-build-push branch from 273c812 to bdf890d Compare June 17, 2021 21:41
@adellape
Copy link
Contributor Author

@estroz PTAL for tech review of "catalog-build" and "catalog-push" related docs for OCP 4.8. 🙇

@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 18, 2021
@ahardin-rh
Copy link
Contributor

@adellape Just some minor suggestions from me. 👍

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 18, 2021
@emmajiafan
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@adellape adellape force-pushed the catalog-build-push branch from bdf890d to 68c013d Compare June 21, 2021 16:39
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
Copy link

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one clarification then lgtm

@adellape adellape force-pushed the catalog-build-push branch from 68c013d to 1c16fee Compare June 23, 2021 21:25
@adellape adellape merged commit 771ee82 into openshift:master Jun 23, 2021
@adellape adellape deleted the catalog-build-push branch June 23, 2021 21:43
@adellape
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@adellape: new pull request created: #33857

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants