[RFE] Router sets its dns name in admitted routes#3377
[RFE] Router sets its dns name in admitted routes#3377bfallonf merged 1 commit intoopenshift:masterfrom
Conversation
|
@knobunc First draft of router DNS Name doc changes PTAL |
pecameron
force-pushed
the
bz1393489
branch
2 times, most recently
from
9b9c17e to
ad44b94
Compare
|
@knobunc changed from dns name to hostname PTAL |
pecameron
force-pushed
the
bz1393489
branch
2 times, most recently
from
cdab728 to
d5529ff
Compare
|
@knobunc changed to --router-canonical-hostname and ROUTER_CANONICAL_HOSTNAME |
There was a problem hiding this comment.
?
The point is that the end user should set up their DNS with a CNAME that points at this hostname.
There was a problem hiding this comment.
Say deployment config not dc (here and throughout)
There was a problem hiding this comment.
Hopefully the cluster administrator documents how to make that selection if multiple admit the route...
There was a problem hiding this comment.
@knobunc Isn't router to application a potentially many to one mapping? You can pick any router that admits the route and get traffic to the application. What do you want to say here?
There was a problem hiding this comment.
Should this paragraph be lower? It feels out of order.
There was a problem hiding this comment.
Maybe not network admin, but DNS admin? And ask them to set up a CNAME from ... to ...
|
@knobunc Any further changes needed before moving this along? |
There was a problem hiding this comment.
We need to either say 'host name' or 'hostname' consistently throughout. I think hostname is now preferred in the later RFCs.
There was a problem hiding this comment.
The argument to ... ? The flag itself isn't that...
|
@knobunc PTAL |
|
@openshift/team-documentation tech review complete. Over to you |
|
@bfallonf - PTAL. |
There was a problem hiding this comment.
@pecameron Can I ask: "that is shown in the in route statuses".
Should that be "that is shown in the route status" or should it have markup (is it some sort of parameter or variable) like "that is shown in the IN_ROUTE statuses"
?
There was a problem hiding this comment.
Sure. Thanks @pecameron . I'll merge this and do a followup.
|
@pecameron I just have one question, but when that's answered I can merge and perhaps do some style followups. Otherwise, looks good! |
Openshift 3.5 feature
The router is managed by the cluster admin and the admin knows the
external host name of the router. The user creates routes to route
desired host DNS names to the the application. The user doesn't have
access to the router (which is usually in a different namespace). When
a router admits a route the user needs to work with the external
network admin to point the route's hostname to the router. Previously
the user had to contact the cluster admin to find the host name of the
router.
This change adds the --router-canonical-hostname= option to oadm router
which creates and populates the ROUTER_CANONICAL_HOSTNAME environment
variable in the router's dc. This is a string that contains the
canonical hostname of the router. Whenever the router reloads and
evaluates the routes the route's status is edited to include the
router's host name so the user can quickly access the information. If
the ROUTER_CANONICAL_HOSTNAME is updated or added to an existing router
the new information is updated in the admitted routes on the next reload.
The route (oc get route <routename> -o yaml) status reports the name
of the router(s) that have admitted the route. This change adds the
Router's host name to the status in the route.
The information is also reported in "oc describe route" as shown below.
Example:
oadm router myroutername --router-canonical-hostname=oh.my.heavens.org
oc get dc/myroutername -o yaml
...
spec:
template:
spec:
containers:
- env:
- name: ROUTER_CANONICAL_HOSTNAME
value: oh.my.heavens.org
oc get route hello-route3 -o yaml
...
status:
ingress:
- conditions:
- lastTransitionTime: 2016-12-07T15:20:57Z
status: "True"
type: Admitted
host: hello-openshift-v3.not.in3.mycloud.com
routerCanonicalHostname: oh.my.heavens.org
routerName: myroutername
wildcardPolicy: None
oc describe route/hello-route3
...
Requested Host: hello-openshift-v3.not.in3.mycloud.com
exposed on router myroutername (host oh.my.heavens.org) 12
minutes ago
bug 1393489
https://bugzilla.redhat.com/show_bug.cgi?id=1393489
Resolves origin-web-console issue 336
Trello:
https://trello.com/c/BLASUOQC/376-5-add-a-way-to-pass-a-preferred-dns-name-to-routers-to-populate-route-statuses-ingress-usability
openshift/origin#12195
Signed-off-by: Phil Cameron <pcameron@redhat.com>
4 participants
Openshift 3.5 feature
The router is managed by the cluster admin and the admin knows the
external host name of the router. The user creates routes to route
desired host DNS names to the the application. The user doesn't have
access to the router (which is usually in a diffeent namespace). When
a router admits a route the user needs to work with the external
network admin to point the route's hostname to the router. Previously
the user had to contact the cluster admin to find the host name of the
router.
This change adds the --router-canonical-hostname= option to oadm router
which creates and populates the ROUTER_CANONICAL_HOSTNAME environment
variable in the router's dc. This is a string that contains the
canonical hostname of the router. Whenever the router reloads and
evaluates the routes the route's status is edited to include the router's
host name so the user can quickly access the information. If the
ROUTER_CANONICAL_HOSTNAME is updated or added to an existing router the
new information is updated in the admitted routes on the next reload.
The route (oc get route -o yaml) status reports the name
of the router(s) that have admitted the route. This change adds the
Router's host name to the status in the route.
The information is also reported in "oc describe route" as shown below.
Example:
oadm router myroutername --router-canonical-hostname=oh.my.heavens.org
oc get dc/myroutername -o yaml
...
spec:
template:
spec:
containers:
- env:
- name: ROUTER_CANONICAL_HOSTNAME
value: oh.my.heavens.org
oc get route hello-route3 -o yaml
...
status:
ingress:
status: "True"
type: Admitted
host: hello-openshift-v3.not.in3.mycloud.com
routerCanonicalHostname: oh.my.heavens.org
routerName: myroutername
wildcardPolicy: None
oc describe route/hello-route3
...
Requested Host: hello-openshift-v3.not.in3.mycloud.com
exposed on router myroutername (host oh.my.heavens.org) 12
minutes ago
bug 1393489
🚶♂️ https://bugzilla.redhat.com/show_bug.cgi?id=1393489
Resolves origin-web-console issue 336
Trello:
https://trello.com/c/BLASUOQC/376-5-add-a-way-to-pass-a-preferred-dns-name-to-routers-to-populate-route-statuses-ingress-usability
openshift/origin#12195
Signed-off-by: Phil Cameron pcameron@redhat.com