-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update Ignition spec 2.2.0 configs; clean up some configs #33957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 6b479c3 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dba98ab6a11100073b625f 😎 Browse the preview: https://deploy-preview-33957--osdocs.netlify.app |
|
LGTM! |
miabbott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but otherwise LGTM
- Update remaining Ignition spec 2.2.0 configs to 3.1.0 - Drop obsolete or empty fields - Sort some sections into a more logical field order - Convert decimal file modes to octal - Drop media type from data URLs - Unquote file path - Consistently use overwrite: true in SCTP docs
|
Updated, including a few more small cleanups. |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
@bobfuru: new pull request created: #34134 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: #33957 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: #33957 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
overwrite: truein SCTP docscc @bobfuru @miabbott