removed --api-version flag which is deprecated#3446
Closed
sjwalter2 wants to merge 2 commits intoopenshift:masterfrom
sjwalter2:regfix
Closed
removed --api-version flag which is deprecated#3446sjwalter2 wants to merge 2 commits intoopenshift:masterfrom sjwalter2:regfix
sjwalter2 wants to merge 2 commits intoopenshift:masterfrom
sjwalter2:regfix
Conversation
Contributor
|
@sjwalter2 Thanks for this! LGTM. Can you please give this a squash? |
Author
|
Sorry, I'm still a git noob when it comes to anything not a personal project. How do I squash? I can also ping you in irc on monday |
Contributor
|
@sjwalter2 No worries! You can follow these instructions. We just want to condense multiple commits into one commit so that our docs team can cherry-pick and publish the changes cleanly. Let me know if you have any questions. Thanks! |
Contributor
|
@sjwalter2 Once you get this squashed, just let me know and I will merge it. Thanks! |
Contributor
|
Closing in favor of #3581 to move this along |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs specify to use the flag
--api-version=v1. However, this is a deprecated flag and is not respected by the oc client, thus we should not need to keep it. This is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1379434