Skip to content

SRVKE-652: Container source docs #34707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abrennan89 merged 1 commit into from
Jul 28, 2021
Merged

SRVKE-652: Container source docs #34707

abrennan89 merged 1 commit into from
Jul 28, 2021

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jul 19, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2021
@abrennan89 abrennan89 added this to the Next Release milestone Jul 19, 2021
@netlify
Copy link

netlify bot commented Jul 19, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: bc45f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6101717596065c0007d4bade

😎 Browse the preview: https://deploy-preview-34707--osdocs.netlify.app

@abrennan89 abrennan89 force-pushed the SRVKE-652 branch 2 times, most recently from 2ce87bb to 67cadf4 Compare July 19, 2021 18:53
@lberk
Copy link
Member

lberk commented Jul 19, 2021

from an eventing perspective it LGTM

@dsimansk
Copy link

dsimansk commented Jul 20, 2021

@abrennan89 from the CLI point of view it looks LGTM.

cardil
cardil suggested changes Jul 21, 2021
View reviewed changes
@abrennan89 abrennan89 force-pushed the SRVKE-652 branch 2 times, most recently from 65d1f90 to 132a7ab Compare July 27, 2021 17:46
cardil
cardil approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from QE

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
bobfuru
bobfuru reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions but overall this looks really good.

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 27, 2021
@abrennan89 abrennan89 requested review from cardil and rhuss July 27, 2021 21:09
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@bobfuru
Copy link
Contributor

bobfuru commented Jul 28, 2021

LGTM!

@abrennan89 abrennan89 merged commit 70ab7c3 into openshift:main Jul 28, 2021
@abrennan89
Copy link
Contributor Author

abrennan89 commented Jul 28, 2021

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor Author

abrennan89 commented Jul 28, 2021

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

abrennan89 commented Jul 28, 2021

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor Author

abrennan89 commented Jul 28, 2021

/cherrypick enterprise-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 28, 2021

@abrennan89: new pull request created: #34939

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 28, 2021

@abrennan89: new pull request created: #34940

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 28, 2021

@abrennan89: new pull request created: #34941

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 28, 2021

@abrennan89: new pull request created: #34942

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
@abrennan89 abrennan89 deleted the SRVKE-652 branch December 17, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cardil cardil Awaiting requested review from cardil

@rhuss rhuss Awaiting requested review from rhuss

1 more reviewer

@bobfuru bobfuru bobfuru left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cardil cardil

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@abrennan89 @lberk @dsimansk @bobfuru @openshift-cherrypick-robot @rhuss @cardil