TELCODOCS-82: RAN policies #34801

StephenJamesSmith · 2021-07-22T18:51:58Z

For version 4.8 Webscale Dev Preview

https://issues.redhat.com/browse/TELCODOCS-82

Direct link to doc preview: https://deploy-preview-34801--osdocs.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp-deploying-disconnected

Signed-off-by: Stephen Smith stesmith@redhat.com

netlify · 2021-07-22T18:53:28Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 54d70b2

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60fc0a2a1659d5000824a989

😎 Browse the preview: https://deploy-preview-34801--osdocs.netlify.app

skrthomas

A few comments for you and some suggestions. Nice work!! 💯

skrthomas · 2021-07-22T20:14:03Z

modules/ztp-applying-the-ran-policies-for-monitoring-cluster-activity.adoc

/ Module included in the following assemblies: is appearing in the preview, FYI.

Oops. Changed.

skrthomas · 2021-07-22T20:14:53Z

modules/ztp-applying-source-custom-resource-policies.adoc

/ Module included in the following assemblies: is appearing in the preview, FYI.

skrthomas · 2021-07-22T20:15:08Z

modules/ztp-generating-ran-policies.adoc

/ Module included in the following assemblies: is appearing in the preview, FYI.

Sigh. changed.

skrthomas · 2021-07-22T20:16:20Z

modules/ztp-things-to-consider-when-creating-custom-resource-policies.adoc

Included in preview.

skrthomas · 2021-07-22T20:17:01Z

modules/ztp-things-to-consider-when-creating-custom-resource-policies.adoc

s/ Things to consider/ Considerations when creating...

skrthomas · 2021-07-22T20:18:08Z

modules/ztp-things-to-consider-when-creating-custom-resource-policies.adoc

s/ will not be/ do(es) not -->avoid future tense

Changed: "Subscription source files do not change."

skrthomas · 2021-07-22T20:20:36Z

modules/ztp-applying-source-custom-resource-policies.adoc

include the following: --> I've always been told to introduce a list with a complete sentence.

Change made.

juphoff · 2021-07-22T21:05:43Z

modules/ztp-applying-source-custom-resource-policies.adoc

Typo--extra backtick in `S`riovNetworkNodePolicy` at end of line.

juphoff · 2021-07-22T21:16:06Z

modules/ztp-the-policygentemplate.adoc

As mentioned for other files, this line is showing up in the preview.

juphoff · 2021-07-22T21:26:59Z

modules/ztp-the-policygentemplate.adoc

Perhaps clarify beginning of second sentence with structure paralleling the end of the first?

It defines a MachineConfigPool named worker-du that is used...

juphoff

Left a small number of minor-correction comments.

/lgtm

openshift-ci · 2021-07-22T21:31:19Z

@juphoff: changing LGTM is restricted to collaborators

Details

In response to this:

Left a small number of minor-correction comments.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

StephenJamesSmith · 2021-07-23T13:53:04Z

@ijolliffe All changes made. Please /lgtm if you haven't yet. Thx!

ijolliffe · 2021-07-23T14:49:28Z

/lgtm

openshift-ci · 2021-07-24T12:40:10Z

New changes are detected. LGTM label has been removed.

StephenJamesSmith · 2021-07-24T12:44:13Z

@vikram-redhat Distros: openshift-webscale added back to topic map, Final assembly file included. Please merge.

bergerhoffer · 2021-07-26T15:04:33Z

/cherrypick enterprise-4.8

openshift-cherrypick-robot · 2021-07-26T15:05:21Z

@bergerhoffer: new pull request created: #34845

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2021

skrthomas reviewed Jul 22, 2021

View reviewed changes

juphoff reviewed Jul 22, 2021

View reviewed changes

modules/ztp-the-policygentemplate.adoc Outdated

Copy link

juphoff Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned for other files, this line is showing up in the preview.

juphoff reviewed Jul 22, 2021

View reviewed changes

juphoff approved these changes Jul 22, 2021

View reviewed changes

StephenJamesSmith changed the title ~~telcodocs-82-ran-policies- peer review~~ TELCODOCS-82: RAN policies Jul 23, 2021

StephenJamesSmith force-pushed the telcodocs-82-ran-policies branch from d0309ee to ee7435c Compare July 23, 2021 13:44

openshift-ci bot assigned ijolliffe Jul 23, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

telcodocs-82-ran-policies- peer review

54d70b2

StephenJamesSmith force-pushed the telcodocs-82-ran-policies branch from ee7435c to 54d70b2 Compare July 24, 2021 12:40

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2021

vikram-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 25, 2021

vikram-redhat added this to the Future Release milestone Jul 25, 2021

vikram-redhat added the branch/enterprise-4.8 label Jul 25, 2021

vikram-redhat approved these changes Jul 25, 2021

View reviewed changes

vikram-redhat merged commit 93b37c3 into openshift:master Jul 25, 2021

openshift-cherrypick-robot mentioned this pull request Jul 26, 2021

[enterprise-4.8] TELCODOCS-82: RAN policies #34845

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.8 GA Jul 27, 2021

TELCODOCS-82: RAN policies #34801

TELCODOCS-82: RAN policies #34801

Conversation

StephenJamesSmith commented Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skrthomas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StephenJamesSmith Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juphoff Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juphoff Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juphoff left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 22, 2021

Uh oh!

StephenJamesSmith commented Jul 23, 2021

Uh oh!

ijolliffe commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 24, 2021

Uh oh!

StephenJamesSmith commented Jul 24, 2021

Uh oh!

bergerhoffer commented Jul 26, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

StephenJamesSmith commented Jul 22, 2021 •

edited

Loading

netlify bot commented Jul 22, 2021 •

edited

Loading

StephenJamesSmith Jul 22, 2021 •

edited

Loading

juphoff Jul 22, 2021 •

edited

Loading

juphoff Jul 22, 2021 •

edited

Loading