Skip to content

Conversation

@skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Aug 3, 2021

Including GCP Global Access module in assembly where it is missing. For 4.8+

Related to #33611 where this module should've been included but was missed.

Preview: https://deploy-preview-35149--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-private.html#nw-gcp-global-access-configuration_installing-gcp-private

@makentenza ready for review.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2021
@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 6ba4fc4

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6109a5c4f34b600007fff335

😎 Browse the preview: https://deploy-preview-35149--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-private

@makentenza
Copy link
Contributor

LGTM

@jeana-redhat jeana-redhat added branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR labels Aug 3, 2021
@jeana-redhat jeana-redhat merged commit 31f460a into openshift:main Aug 3, 2021
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.9

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #35151

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #35152

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants