OSDOCS-2456: adding procedure for customizing ingress error pages #36065
Conversation
openshift-ci
bot
added
the
size/M
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: bb48461 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61572cb19b82e80007157fec 😎 Browse the preview: https://deploy-preview-36065--osdocs.netlify.app/openshift-enterprise/latest/networking/ingress-operator |
skrthomas
force-pushed
the
OSDOCS-2456
branch
2 times, most recently
from
754ae62 to
93283d4
Compare
jboxman
left a comment
jboxman
left a comment
There was a problem hiding this comment.
@skrthomas, drive-by comments. We're using config map and code font for object names and name space names.
skrthomas
force-pushed
the
OSDOCS-2456
branch
3 times, most recently
from
20e7b2d to
de78741
Compare
skrthomas
force-pushed
the
OSDOCS-2456
branch
5 times, most recently
from
4054cd2 to
acdd81d
Compare
|
@skrthomas PTAL at my comments. Thanks for working on this! |
skrthomas
force-pushed
the
OSDOCS-2456
branch
3 times, most recently
from
bc2b01d to
99ece85
Compare
openshift-ci
bot
added
size/L
skrthomas
force-pushed
the
OSDOCS-2456
branch
7 times, most recently
from
53f8000 to
c8d839c
Compare
skrthomas
force-pushed
the
OSDOCS-2456
branch
from
c8d839c to
b69391a
Compare
|
@skrthomas lgtm |
mikemckiernan
left a comment
mikemckiernan
left a comment
There was a problem hiding this comment.
As always, please let me know what I can clarify.
mikemckiernan
added
the
peer-review-done
skrthomas
force-pushed
the
OSDOCS-2456
branch
5 times, most recently
from
8bb2ba7 to
66844e5
Compare
mikemckiernan
left a comment
mikemckiernan
left a comment
There was a problem hiding this comment.
Nits, comments, and up-to-yous. Please let me know what I can clarify.
skrthomas
force-pushed
the
OSDOCS-2456
branch
4 times, most recently
from
7f0e1db to
00bf129
Compare
mikemckiernan
left a comment
mikemckiernan
left a comment
There was a problem hiding this comment.
A few more items. Apologies if these are items that I overlooked previously and that I'm burning your time.
|
/cherrypick enterprise-4.9 |
|
@mikemckiernan: new pull request created: #36983 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
Jira story: https://issues.redhat.com/browse/OSDOCS-2456
For 4.9
Preview: https://deploy-preview-36065--osdocs.netlify.app/openshift-enterprise/latest/networking/ingress-operator?utm_source=github&utm_campaign=bot_dp#nw-customize-ingress-error-pages_configuring-ingress
@miheer release notes and known issues are in this PR: #36498
Known Issue: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-9-known-issues
RN: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-9-networking