OSDOCS-2477: Adds prerequisite step to updating cluster #36225

opayne1 · 2021-09-09T14:44:11Z

applies to enterprise-4.9+
Preview link for Updating a cluster within a minor version from the web console
Preview link for Updating a cluster within a minor version by using the CLI

netlify · 2021-09-09T14:47:04Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: f37bfb1

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6157182e7b06a8000790ee14

😎 Browse the preview: https://deploy-preview-36225--osdocs.netlify.app/openshift-enterprise/latest/updating/updating-cluster

spadgett · 2021-09-09T15:42:44Z

updating/updating-cluster-cli.adoc

I think we need some guidance around how an admin can check this.

cc @sdodson

Reading through OSDOCS-2477 and the epic it's linked to I would interpret this to just mean that the admin addresses any of the conditions triggered by Upgradeable=False displayed either by the Console or oc adm upgrade cli command. I'm sure how to best address that in docs, perhaps something like the following

You must address any outstanding Upgradeable=False conditions before the cluster will allow an upgrade to the next minor. The output of oc adm upgrade will list all Upgradeable=False conditions and reasons for those conditions which will help you prepare for a minor version upgrade.

updating/updating-cluster-cli.adoc

sdodson · 2021-09-17T18:05:41Z

updating/updating-cluster.adoc

This looks fine to me, but the admin console also displays these. As written this will work too but I don't know if we want to split the context between the cli upgrade and the admin console upgrade.

openshift/console#9329 illustrates how the admin console shows these in case you don't have a 4.9 cluster in front of you to look at

@rhamilto Where is this displayed? Is it the banner that is at the top of the page?

@opayne1 It's an alert at the top of the Administration -> Cluster Settings page.

@spadgett @sdodson I watched the sprint demo of this as well. Am I making sense of this correctly?

Suggested change

* Ensure you address all Upgradeable=False conditions so the cluster will allow an upgrade to the next minor version. You can run the command `oc adm upgrade` for an output of all Upgradeable=False conditions and the condition reasoning to help you prepare for a minor version upgrade.

Ensure you address all Upgradeable=False conditions so the cluster will allow an upgrade to the next minor version. An alert will display at the top of the *Cluster Settings* page when you have one or more ClusterOperators that can not be upgraded. You will still be able to upgrade to the next available patch update for the minor release you are currently on.

@opayne1 yeah that sounds good to me.

opayne1 · 2021-09-28T13:43:18Z

@yapei Please provide QE review for this. Thank you!

yapei · 2021-09-29T09:54:29Z

the changes look good to me ~ ack

bergerhoffer

Just a few minor nits!

bergerhoffer · 2021-09-29T12:48:12Z

updating/updating-cluster-cli.adoc

Ensure -> Ensure that

Suggest putting Upgradeable=False in backticks (2 places in this bullet)

cluster will allow -> cluster allows (to avoid future tense)

I'd put "command" after oc adm upgrade

bergerhoffer · 2021-09-29T12:49:48Z

updating/updating-cluster.adoc

Same comments from the above file (where applicable), plus:

An alert will display -> An alert displays

ClusterOperators -> cluster Operators

can not -> cannot

Reword "You will still be able to" to get rid of the future tense. Maybe "You can still"?

stevsmit · 2021-10-01T13:39:59Z

updating/updating-cluster-cli.adoc

backticks around second Upgradeable-False

stevsmit · 2021-10-01T13:44:05Z

updating/updating-cluster.adoc

s/ will allow/ allows

stevsmit · 2021-10-01T14:29:07Z

lgtm!

bobfuru · 2021-10-01T14:31:21Z

/cherrypick enterprise-4.9

openshift-cherrypick-robot · 2021-10-01T14:32:03Z

@bobfuru: new pull request created: #36973

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2021

spadgett reviewed Sep 9, 2021

View reviewed changes

opayne1 force-pushed the OSDOCS-2477 branch from f009104 to 5d6679b Compare September 17, 2021 15:19

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021

opayne1 force-pushed the OSDOCS-2477 branch from 5d6679b to e88a72b Compare September 17, 2021 15:30

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2021

opayne1 force-pushed the OSDOCS-2477 branch 2 times, most recently from 2e5bf81 to c73a0cd Compare September 17, 2021 15:37

openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2021

opayne1 force-pushed the OSDOCS-2477 branch 2 times, most recently from e8a108b to c1e5d03 Compare September 17, 2021 15:43

opayne1 commented Sep 17, 2021

View reviewed changes

updating/updating-cluster-cli.adoc Outdated Show resolved Hide resolved

sdodson reviewed Sep 17, 2021

View reviewed changes

opayne1 force-pushed the OSDOCS-2477 branch from c1e5d03 to f97c1e3 Compare September 22, 2021 18:37

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2021

opayne1 force-pushed the OSDOCS-2477 branch from f97c1e3 to b1e23fe Compare September 22, 2021 18:50

openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2021

opayne1 force-pushed the OSDOCS-2477 branch from b1e23fe to ad41e60 Compare September 22, 2021 19:01

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2021

opayne1 changed the base branch from enterprise-4.9 to main September 22, 2021 19:01

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2021

opayne1 force-pushed the OSDOCS-2477 branch from ad41e60 to d92eb5d Compare September 28, 2021 13:39

bergerhoffer added branch/enterprise-4.9 peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 29, 2021

bergerhoffer added this to the Future Release milestone Sep 29, 2021

bergerhoffer reviewed Sep 29, 2021

View reviewed changes

bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 29, 2021

opayne1 force-pushed the OSDOCS-2477 branch 2 times, most recently from 9e63637 to f92694a Compare September 29, 2021 14:57

stevsmit reviewed Oct 1, 2021

View reviewed changes

opayne1 force-pushed the OSDOCS-2477 branch from f92694a to 0288c1a Compare October 1, 2021 13:54

OSDOCS-2477: Adds prerequisite step to updating cluster

f37bfb1

opayne1 force-pushed the OSDOCS-2477 branch from 0288c1a to f37bfb1 Compare October 1, 2021 14:16

bobfuru merged commit 4e057fb into openshift:main Oct 1, 2021

openshift-cherrypick-robot mentioned this pull request Oct 1, 2021

[enterprise-4.9] OSDOCS-2477: Adds prerequisite step to updating cluster #36973

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.9 GA Oct 18, 2021

	* Ensure you address all Upgradeable=False conditions so the cluster will allow an upgrade to the next minor version. You can run the command `oc adm upgrade` for an output of all Upgradeable=False conditions and the condition reasoning to help you prepare for a minor version upgrade.
	Ensure you address all Upgradeable=False conditions so the cluster will allow an upgrade to the next minor version. An alert will display at the top of the Cluster Settings page when you have one or more ClusterOperators that can not be upgraded. You will still be able to upgrade to the next available patch update for the minor release you are currently on.

OSDOCS-2477: Adds prerequisite step to updating cluster #36225

OSDOCS-2477: Adds prerequisite step to updating cluster #36225

Uh oh!

Conversation

opayne1 commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdodson Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

opayne1 commented Sep 28, 2021

Uh oh!

yapei commented Sep 29, 2021

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevsmit commented Oct 1, 2021

Uh oh!

bobfuru commented Oct 1, 2021

Uh oh!

openshift-cherrypick-robot commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

opayne1 commented Sep 9, 2021 •

edited

Loading

netlify bot commented Sep 9, 2021 •

edited

Loading

sdodson Sep 9, 2021 •

edited

Loading