BZ1997337: move SAN certificate feature from deprecated to removed features list in 4.6 #36324
Conversation
|
@chinmayi-chandrasekar: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
needs-rebase
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 895dd1a 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/614ac050c6d76c000732e51c 😎 Browse the preview: https://deploy-preview-36324--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-6-release-notes |
openshift-ci
bot
added
size/S
sagidlow
added
branch/enterprise-4.6
branch/enterprise-4.7
branch/enterprise-4.8
branch/enterprise-4.9
peer-review-needed
sagidlow
removed
branch/enterprise-4.7
branch/enterprise-4.8
branch/enterprise-4.9
needs-rebase
sagidlow
left a comment
sagidlow
left a comment
There was a problem hiding this comment.
I left two comments, otherwise LGTM.
There was a problem hiding this comment.
| ==== TLS verification falling back to the Common Name field | |
| ==== TLS verification falling back to the *Common Name* field |
Per the IBM Style Guide, we should be bolding field names.
There was a problem hiding this comment.
Addressed.
There was a problem hiding this comment.
| The behavior of falling back to the Common Name field on X.509 certificates as a host name when no Subject Alternative Names are present is removed. Certificates must properly set the Subject Alternative Names field. | |
| The behavior of falling back to the *Common Name* field on X.509 certificates as a host name when no Subject Alternative Names are present is removed. Certificates must properly set the *Subject Alternative Names* field. |
Per the IBM Style Guide, we should be bolding field names.
Subject Alternative Names are capitalized like acronyms. If it is not a proper noun then it needs to be in lower case. If it is a field, then it needs to be bolded and identified as a field.
There was a problem hiding this comment.
Addressed.
sagidlow
added
peer-review-done
chinmayi-chandrasekar
force-pushed
the
BZ1997337_SAN_certificate_feature_RN_4.6
branch
from
25b0ec9 to
a73e5d5
Compare
There was a problem hiding this comment.
suggest to add keyword 'removed', like 'TLS verification falling back to the Common Name field removed'
chinmayi-chandrasekar
force-pushed
the
BZ1997337_SAN_certificate_feature_RN_4.6
branch
from
a73e5d5 to
e2e8b2a
Compare
|
/lgtm |
|
/lgtm |
…ature list in 4.6
chinmayi-chandrasekar
force-pushed
the
BZ1997337_SAN_certificate_feature_RN_4.6
branch
from
e2e8b2a to
895dd1a
Compare
|
New changes are detected. LGTM label has been removed. |
|
Since the support status of a feature is changing after GA, we need to follow change management for this. |
6 participants
Applies only to 4.6
Docs preview link: https://deploy-preview-36324--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-6-release-notes?utm_source=github&utm_campaign=bot_dp
https://bugzilla.redhat.com/show_bug.cgi?id=1997337
Requires ack from @yaoli-redhat @sttts @Anandnatraj