Bug 1396340 Update to example daemonset definition#3740
Merged
bmcelvee merged 1 commit intoopenshift:masterfrom Mar 14, 2017
Merged
Bug 1396340 Update to example daemonset definition#3740bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
@mburke5678 @ahardin-rh peer review please 😺 |
Contributor
|
LGTM! |
Contributor
|
LGTM2 |
|
@bmcelvee there are two issue in this bug, you only fix one.
The ' unable to decode....' also need fix, please remove "-" in the yaml file first line and make foo.yaml aligned. Detail the bug: #3243 |
Contributor
Author
|
Thanks, @mdshuai! I removed the hyphen and extraneous spaces. |
|
LGTM, thanks |
Contributor
Author
|
[rev_history] |
Contributor
Author
|
Thanks all! |
Contributor
|
@bmcelvee - needs a milestone. |
Contributor
Author
|
Thanks, @vikram-redhat! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1396340