Skip to content

Comments

Bug 1396340 Update to example daemonset definition#3740

Merged
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:BZ1396340
Mar 14, 2017
Merged

Bug 1396340 Update to example daemonset definition#3740
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:BZ1396340

Conversation

@bmcelvee
Copy link
Contributor

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Mar 8, 2017

@mburke5678 @ahardin-rh peer review please 😺

@ahardin-rh
Copy link
Contributor

LGTM!

@mburke5678
Copy link
Contributor

LGTM2

@mdshuai
Copy link

mdshuai commented Mar 9, 2017

@bmcelvee there are two issue in this bug, you only fix one.

  1. unable to decode "foo.yaml": json: cannot unmarshal array into Go value of type unversioned.TypeMeta
  2. name error is fixed in the current pr.

The ' unable to decode....' also need fix, please remove "-" in the yaml file first line and make foo.yaml aligned.

Detail the bug: #3243

@bmcelvee
Copy link
Contributor Author

Thanks, @mdshuai! I removed the hyphen and extraneous spaces.

@mdshuai
Copy link

mdshuai commented Mar 14, 2017

LGTM, thanks

@bmcelvee
Copy link
Contributor Author

[rev_history]
|xref:../admin_guide/manage_authorization_policy.adoc#admin-guide-manage-authorization-policy[Managing Authorization Policies]
|Updated the ClusterRole file in the xref:../admin_guide/manage_authorization_policy.adoc#admin-guide-granting-users-daemonset-permissions[Granting Users Daemonset Permissions] section.
%

@bmcelvee
Copy link
Contributor Author

Thanks all!

@bmcelvee bmcelvee merged commit da4eef9 into openshift:master Mar 14, 2017
@vikram-redhat
Copy link
Contributor

@bmcelvee - needs a milestone.

@bmcelvee
Copy link
Contributor Author

Thanks, @vikram-redhat!

@bmcelvee bmcelvee added this to the Next Release milestone Mar 15, 2017
@ahardin-rh ahardin-rh modified the milestones: Next Release, Staging, Published 03/20/2017 Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants