-
Notifications
You must be signed in to change notification settings - Fork 1.8k
SRVKS-789: Move steps for enabling Serving metrics despite Service Mesh & mTLS #37573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EricPonvelle
merged 1 commit into
openshift:main
from
rh-max:srvls-serving-metrics-mesh-mtls
Oct 20, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
[id="serverless-ossm-enabling-serving-metrics_{context}"] | ||
= Enabling Knative Serving metrics when using Service Mesh with mTLS | ||
|
||
If Service Mesh is enabled with mTLS, metrics for Knative Serving are disabled by default, because Service Mesh prevents Prometheus from scraping metrics. This section shows how to enable Knative Serving metrics when using Service Mesh and mTLS. | ||
|
||
.Prerequisites | ||
|
||
* You have installed the {ServerlessOperatorName} on your {product-title} cluster. | ||
* You have installed {ProductName} with the mTLS functionality enabled. | ||
* You have installed Knative Serving. | ||
|
||
.Procedure | ||
|
||
. Specify `prometheus` as the `metrics.backend-destination` in the `observability` spec of the Knative Serving custom resource (CR): | ||
+ | ||
[source,yaml] | ||
---- | ||
apiVersion: operator.knative.dev/v1beta1 | ||
kind: KnativeServing | ||
metadata: | ||
name: knative-serving | ||
spec: | ||
config: | ||
observability: | ||
metrics.backend-destination: "prometheus" | ||
---- | ||
+ | ||
This step prevents metrics from being disabled by default. | ||
|
||
. Apply the following network policy to allow traffic from the Prometheus namespace: | ||
+ | ||
[source,yaml] | ||
---- | ||
apiVersion: networking.k8s.io/v1 | ||
kind: NetworkPolicy | ||
metadata: | ||
name: allow-from-openshift-monitoring-ns | ||
namespace: knative-serving | ||
spec: | ||
ingress: | ||
- from: | ||
- namespaceSelector: | ||
matchLabels: | ||
name: "openshift-monitoring" | ||
podSelector: {} | ||
---- | ||
|
||
. Modify and reapply the default Service Mesh control plane in the `istio-system` namespace, so that it includes the following spec: | ||
+ | ||
[source,yaml] | ||
---- | ||
spec: | ||
proxy: | ||
networking: | ||
trafficControl: | ||
inbound: | ||
excludedPorts: | ||
- 8444 | ||
---- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.