Skip to content

Conversation

@mgarrell777
Copy link
Contributor

@mgarrell777 mgarrell777 commented Oct 15, 2021

This PR addresses Bug 1986962 (https://bugzilla.redhat.com/show_bug.cgi?id=1986962) mirrored in JIRA story CNV-13237 (https://issues.redhat.com/browse/CNV-13237)

The bug is about modifying the CPU requirements for worker node VMs to not mention specific vendors, making them more agnostic in the process

CP: 4.9, 4.10

Preview: Bullet starting with "If your cluster uses worker nodes with different CPUs" in https://deploy-preview-37582--osdocs.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2021
@netlify
Copy link

netlify bot commented Oct 15, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 6b70578

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61699ff4374c6a0008df4f99

😎 Browse the preview: https://deploy-preview-37582--osdocs.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt

@mgarrell777
Copy link
Contributor Author

Dev approval by Martijn Ten Heuvel provided in comments of JIRA https://issues.redhat.com/browse/CNV-13237

@rnetser
Copy link

rnetser commented Oct 19, 2021

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

@rnetser: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjhala-ccs sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 19, 2021
@sjhala-ccs sjhala-ccs merged commit 59fcceb into openshift:main Oct 19, 2021
@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.10

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #37677

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #37678

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #37679

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants