Skip to content

Conversation

@rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Oct 22, 2021

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2021
@netlify
Copy link

netlify bot commented Oct 22, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: e6efcc5

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/617a9e1fb796a90008b854aa

😎 Browse the preview: https://deploy-preview-37893--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2021
@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 22, 2021

I closed this previous PR because it was on the wrong release branch: #37846

Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments @rolfedh

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 28, 2021

@gabemontero
Copy link
Contributor

LGTM

per the SME's listed in the description, definitely get @adambkaplan 's sign off as well

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@abrennan89 abrennan89 added branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR labels Oct 28, 2021
@abrennan89 abrennan89 merged commit 3001279 into openshift:enterprise-4.9 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants