Skip to content

[TELCODOCS-323] - CNF-2772 PTP updates for OpenShift 4.10 #39713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lpettyjo merged 1 commit into from
Feb 25, 2022
Merged

[TELCODOCS-323] - CNF-2772 PTP updates for OpenShift 4.10 #39713

lpettyjo merged 1 commit into from
Feb 25, 2022

Conversation

@aireilly
Copy link
Contributor

@aireilly aireilly commented Dec 9, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2021
@netlify
Copy link

netlify bot commented Dec 9, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 3dd755f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6218d59a5923130008f3225f

😎 Browse the preview: https://deploy-preview-39713--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2022
@aireilly aireilly force-pushed the TELCODOCS-323 branch 3 times, most recently from 53c81e8 to 64bec66 Compare January 31, 2022 15:07
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2022
@aireilly aireilly force-pushed the TELCODOCS-323 branch 9 times, most recently from 1b6c312 to 2433919 Compare February 1, 2022 16:06
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2022
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 2, 2022
@aireilly aireilly changed the title TELCODOCS-323 - PTP updates for OCP 4.10 TELCODOCS-323 - CNF-2772 PTP updates for OpenShift 4.10 Feb 2, 2022
@aireilly aireilly force-pushed the TELCODOCS-323 branch 2 times, most recently from 64a3f9f to fe57386 Compare February 2, 2022 12:22
@aireilly aireilly changed the title TELCODOCS-323 - CNF-2772 PTP updates for OpenShift 4.10 [TELCODOCS-323] - CNF-2772 PTP updates for OpenShift 4.10 Feb 2, 2022
@sagidlow sagidlow added branch/enterprise-4.10 peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 22, 2022
@sagidlow sagidlow added this to the Future Release milestone Feb 22, 2022
@aireilly aireilly force-pushed the TELCODOCS-323 branch 2 times, most recently from 59602ab to 3a51ca9 Compare February 22, 2022 22:29
sagidlow
sagidlow reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@sagidlow sagidlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nit comments. Let me know if you have any questions :)

@sagidlow sagidlow added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 22, 2022
@aireilly aireilly requested a review from sagidlow February 24, 2022 13:27
@obochan-rh
Copy link

obochan-rh commented Feb 24, 2022

LGTM

@aireilly aireilly force-pushed the TELCODOCS-323 branch 7 times, most recently from 27f5214 to cc64289 Compare February 25, 2022 13:11
@lpettyjo lpettyjo merged commit 0018b8c into openshift:main Feb 25, 2022
@lpettyjo
Copy link
Contributor

lpettyjo commented Feb 25, 2022

/cherrypick enterprise-4.10

1 similar comment
@lpettyjo
Copy link
Contributor

lpettyjo commented Feb 25, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 25, 2022

@lpettyjo: new pull request created: #42419

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
@aireilly aireilly deleted the TELCODOCS-323 branch March 10, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhatt-rh abhatt-rh abhatt-rh left review comments

@aneeshkp aneeshkp Awaiting requested review from aneeshkp

@imiller0 imiller0 Awaiting requested review from imiller0

@sagidlow sagidlow Awaiting requested review from sagidlow

+1 more reviewer

@yliu127 yliu127 yliu127 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.10 GA

Development

Successfully merging this pull request may close these issues.

10 participants

@aireilly @yliu127 @obochan-rh @lpettyjo @openshift-cherrypick-robot @aneeshkp @imiller0 @abhatt-rh @sagidlow @bobfuru