Skip to content

Comments

Bug 1387520 Add MariaDB Section#4078

Merged
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:BZ1387520
Apr 11, 2017
Merged

Bug 1387520 Add MariaDB Section#4078
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:BZ1387520

Conversation

@bmcelvee
Copy link
Contributor

@bmcelvee bmcelvee commented Apr 5, 2017

@bmcelvee bmcelvee force-pushed the BZ1387520 branch 2 times, most recently from c31a2f0 to 9d94720 Compare April 5, 2017 17:42
@bmcelvee
Copy link
Contributor Author

bmcelvee commented Apr 6, 2017

@adellape @ahardin-rh Please peer review if you have time. Thanks! 😸

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Apr 6, 2017

@vikram-redhat
Copy link
Contributor

@bfallonf @mburke5678 - PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dopey suggesting using "via" with caution. s/'settings in a configuration file (??)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/setup/set up the

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's a template we're supposed to be using for tech previews now:

https://mojo.redhat.com/docs/DOC-1124368

Some of us chatted about it in #3952 , so not sure how much energy wants to go into it. Up to you.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a missing space after the {product-title} thing above?

@bfallonf
Copy link

bfallonf commented Apr 9, 2017

A few nits from me. Overall, this is fine, good job, etc 😄 🚚

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mariadb-persistent template, not mysql-persistent.

Copy link

@wzheng1 wzheng1 Apr 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mariadb-ephemeral template, not mysql-ephemeral.

@bmcelvee bmcelvee changed the title [WIP] Bug 1387520 Add MariaDB Section Bug 1387520 Add MariaDB Section Apr 11, 2017
@bmcelvee
Copy link
Contributor Author

[rev_history]
|xref:../using_images/db_images/mariadb.adoc#using-images-db-images-mariadb[MariaDB]
|Added MariaDB section.
%

@bmcelvee bmcelvee merged commit 4b9bfb0 into openshift:master Apr 11, 2017
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging Apr 12, 2017
@vikram-redhat vikram-redhat modified the milestones: Published - 04/12/2017, Staging Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants