Skip to content

SRVCOM-1728: Update serverless abstracts to align with Jupiter requirements #43288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abrennan89 merged 1 commit into from
Mar 29, 2022
Merged

SRVCOM-1728: Update serverless abstracts to align with Jupiter requirements #43288

abrennan89 merged 1 commit into from
Mar 29, 2022

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Mar 15, 2022 •
edited
Loading

@abrennan89 abrennan89 added this to the Next Release milestone Mar 15, 2022
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2022
@netlify
Copy link

netlify bot commented Mar 15, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit b03a3e8
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/6243296cdee91f0009b6cd04
😎 Deploy Preview https://deploy-preview-43288--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@abrennan89 abrennan89 changed the title [WIP] SRVCOM-1728: Update all serverless abstracts to align with Jupiter requirements [WIP] SRVCOM-1728: Update serverless abstracts to align with Jupiter requirements Mar 16, 2022
@abrennan89 abrennan89 changed the title [WIP] SRVCOM-1728: Update serverless abstracts to align with Jupiter requirements SRVCOM-1728: Update serverless abstracts to align with Jupiter requirements Mar 21, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022
lance
lance reviewed Mar 21, 2022
View reviewed changes
Copy link

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@nak3
Copy link
Contributor

nak3 commented Mar 26, 2022

LGTM!

pierDipi
pierDipi approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maschmid
Copy link
Contributor

maschmid commented Mar 29, 2022

QE approved

@abrennan89 abrennan89 added qe-approved Signifies that QE has signed off on this PR and removed QE Required labels Mar 29, 2022
sagidlow
sagidlow reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@sagidlow sagidlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nit items. Please remember to squash your commits before merging :)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

New changes are detected. LGTM label has been removed.

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 29, 2022
@abrennan89 abrennan89 merged commit 7340454 into openshift:main Mar 29, 2022
@abrennan89
Copy link
Contributor Author

abrennan89 commented Mar 29, 2022

/cherrypick enterprise-4.11

@abrennan89
Copy link
Contributor Author

abrennan89 commented Mar 29, 2022

/cherrypick enterprise-4.10

@abrennan89
Copy link
Contributor Author

abrennan89 commented Mar 29, 2022

/cherrypick enterprise-4.9

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 29, 2022

@abrennan89: new pull request created: #43935

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 29, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 29, 2022

@abrennan89: new pull request created: #43936

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 29, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 29, 2022

@abrennan89: new pull request created: #43937

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 29, 2022
Merged
Merged
Merged
@abrennan89 abrennan89 deleted the SRVCOM-1728 branch June 30, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@lance lance lance left review comments

@sagidlow sagidlow sagidlow left review comments

@pierDipi pierDipi pierDipi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lance lance

@pierDipi pierDipi

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@abrennan89 @nak3 @maschmid @openshift-cherrypick-robot @lance @pierDipi @sagidlow