BZ-2049375:Adds command to Entitlement Build #44472
Conversation
openshift-ci
bot
added
the
size/S
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jldohmann
left a comment
jldohmann
left a comment
There was a problem hiding this comment.
A couple of minor suggestions, but LGTM! 👍
There was a problem hiding this comment.
A small tweak for second person perspective (preferred way per ISG), and to provide an object reference for the Dockerfile command:
| When performing an Entitlement Build using {op-system-base-full} 7 be sure to have the following in your Dockerfile before any `yum` commands: | |
| When you perform an Entitlement Build using {op-system-base-full} 7, you must have the following command in your Dockerfile before you run any `yum` commands: |
The second suggestion about object references is from the supplemental guidelines, and it seems to just mean when you have a literal value within the sentence itself 🙂 but even in an indirect case like this one, I think it adds some clarity
adellape
added
peer-review-done
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.9 |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
@adellape: new pull request created: #44557 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #44558 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #44559 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #44560 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #44561 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
4.7+
BZ 2049375
Preview
Has QE in BZ.