Skip to content

OSDOCS-3533: Added release note for ADFS as supported OIDC provider #45264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

OSDOCS-3533: Added release note for ADFS as supported OIDC provider #45264

merged 1 commit into from
May 23, 2022

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented May 2, 2022 •
edited
Loading

@bergerhoffer bergerhoffer added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.11 labels May 2, 2022
@bergerhoffer bergerhoffer added this to the Future Release milestone May 2, 2022
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2022
@netlify
Copy link

netlify bot commented May 2, 2022

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit eacc5c3
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62704adfb8a23e00088f6d02
😎 Deploy Preview https://deploy-preview-45264--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented May 10, 2022

@xingxingxia for review please!

Preview: https://deploy-preview-45263--osdocs.netlify.app/openshift-enterprise/latest/authentication/identity_providers/configuring-oidc-identity-provider#identity-provider-oidc-supported_configuring-oidc-identity-provider

jldohmann
jldohmann approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

xingxingxia
xingxingxia reviewed May 12, 2022
View reviewed changes
release_notes/ocp-4-11-release-notes.adoc

[NOTE]
====
Currently, it is not supported to use Active Directory Federation Services with {product-title} when custom claims are used.
Copy link
Contributor

@xingxingxia xingxingxia May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more elaborate, would it be better to link https://issues.redhat.com/browse/RFE-2770 (it is public) and/or https://bugzilla.redhat.com/show_bug.cgi?id=2072927?

Copy link
Contributor Author

@bergerhoffer bergerhoffer May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xingxingxia Normally I wouldn't mind linking to a BZ or Jira, but it looks like those have both been closed/rejected. So I don't know if those would be good to link to. It sounds like we're not going to change anything on our end for this, but instead hope that Microsoft will. wdyt?

Copy link
Contributor

@xingxingxia xingxingxia May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, their closed/rejected statuses make it awkward to link them, though they indeed include elaborate info which may be useful. Anyway, let's not link then. Thx

@bergerhoffer bergerhoffer mentioned this pull request May 23, 2022
Merged
@bergerhoffer bergerhoffer merged commit 4c72135 into openshift:enterprise-4.11 May 23, 2022
@bergerhoffer bergerhoffer deleted the OSDOCS-3533-rn branch August 3, 2022 17:19
@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jldohmann jldohmann jldohmann approved these changes

+1 more reviewer

@xingxingxia xingxingxia xingxingxia left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.11 GA

Development

Successfully merging this pull request may close these issues.

4 participants

@bergerhoffer @xingxingxia @jldohmann @kalexand-rh