Skip to content

Conversation

@rohennes
Copy link
Contributor

Taking over Kevin Quinn's PR as he is on PTO. Kevin's original PR is here: #47172

TELCODOCS-780: Promote bond CNI to GA

Version(s):
PR applies to 4.10, 4.11 and main

Issue:
https://issues.redhat.com/browse/TELCODOCS-780

Link to docs preview:
http://file.emea.redhat.com/rohennes/TELCODOCS-780-fixing-modes/networking/hardware_networks/using-pod-level-bonding.html

Item 1. Remove the TP notice
Item 2. Remove the note about BZ#2037214
Item 3. Add the additional bonding options.
Item 4. For bonding options note, mentioned that trust mode must be set to on.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2022
@evgenLevin
Copy link

lgtm

@cgoncalves
Copy link
Contributor

Copying over my comment from #47172 (comment): promotion to General Availability from Tech Preview is worth a release note. Could you please include one?

Also, please extend documentation with a note that the SR-IOV VF link state must not be changed from the default "auto" value (i.e. any other link state value ("enable" or "disable") is not supported). For more context, please refer to https://bugzilla.redhat.com/show_bug.cgi?id=2037214

@rohennes rohennes force-pushed the TELCODOCS-780-fixing-modes branch from 66ba2ca to 246e5c3 Compare July 26, 2022 14:56
@rohennes rohennes changed the title TELCODOCS-780 - Promote bond CNI to GA - taking over from Kevin WIP - TELCODOCS-780 - Promote bond CNI to GA - taking over from Kevin Jul 28, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2022
@mmirecki
Copy link

mmirecki commented Aug 8, 2022

lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2022
@openshift-merge-robot
Copy link

@rohennes: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2022
@rohennes rohennes closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants