Skip to content

Conversation

@kdrake20
Copy link
Contributor

@kdrake20 kdrake20 commented Aug 15, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2022
@kdrake20
Copy link
Contributor Author

kdrake20 commented Aug 15, 2022

Date and Time: August 15, 2022 16:33

Summary: Created content and RN PRs.

Next Steps: Requested reviews from Daniel Erez (SME) and Kerry West (QE).

@kdrake20
Copy link
Contributor Author

@danielerez, could you please review the content and RN PRs? Any comments can be made directly in the PRs. If no changes are needed, please add an lgtm to each PR in Github. Thank you!

@kdrake20
Copy link
Contributor Author

@trewest, could you please review the content and RN PRs? Any comments can be made directly in the PRs. If no changes are needed, please add an lgtm to each PR in Github. Thank you!

@danielerez
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@trewest
Copy link

trewest commented Aug 16, 2022

/lgtm

@kdrake20
Copy link
Contributor Author

Date and Time: August 16, 2022  14:10
Summary: Received /lgtm from Daniel and Kerry. Requested Peer Review from Telco team. 

Next Steps: Implement feedback from Telco Peer Reviews and submit for OCP Review Squad feedback.

@ogradyp
Copy link
Contributor

ogradyp commented Aug 17, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2022

@ogradyp: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
…1 RN to describe the removal of 'rootFSUrl: '<root_fs_url>'' from the file.
@kdrake20
Copy link
Contributor Author

Contact Method: Slack, #forum-doc-review
Date and Time: August 25, 2022 12:51
Summary: Requested review from Peer Review Squad.

Next Steps: Implement feedback from peer reviews and request merge.

Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktothill Is this something that did not make in the release notes with 4.11 GA? If so, we will need to do change management to add that in.

If not, (which I think this is for ZTP that shipped after GA) we will need to work to add this into the appropriate z-stream which may or may not need CM depending on when this needs to merge.

I can help with any questions you have on this. :)

@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://49125--docspreview.netlify.app

@kdrake20
Copy link
Contributor Author

Contact Method: Slack, #forum-docs-review
Date and Time: August 26, 2022 13:23
Summary: Per the Peer Review Squad, RHACM 2.6 GAed on June 8th and that was a 4.10.z as 4.11 wasn't released yet. We may need to complete the Change Management process.

Next Steps: Need to confirm with Emily when she's back on Monday regarding the corresponding .z the content and RN were supposed to be in.

@racedo
Copy link

racedo commented Sep 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@filanov
Copy link

filanov commented Sep 6, 2022

/lgtm

1 similar comment
@ohochman
Copy link

ohochman commented Sep 9, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2022

@ohochman: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdrake20
Copy link
Contributor Author

Contact Method: Slack, #forum-docs-review
Date and Time: September 12, 2022 10:22
Summary: Requested merge for content and RN.

Next Steps: Once PRs are merged, Jira can be closed.

@tradej
Copy link

tradej commented Sep 12, 2022

This content should be added to the 4.11.3 RN section, not in the main RN.

@lpettyjo lpettyjo added this to the Continuous Release milestone Sep 12, 2022
@lpettyjo lpettyjo merged commit c48c8ca into openshift:enterprise-4.11 Sep 12, 2022
@kdrake20
Copy link
Contributor Author

RN should have been placed in 4.11.3. See PR 50328 for correct location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.