-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[enterprise-4.12] OSDOCS-4137: add SE RN entry #51732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/5821 |
|
@SNiemann15 Do you think the RN should have an entry for this in the IBM Z and LinuxONE section too? I realize the content may be duplicated, but I imagine some people jump straight to certain sections that are relevant to them. |
d38ef56 to
38fa000
Compare
|
d38ef56..38fa000 implement Silke feedback |
|
@jldohmann Thanks for bringing that up. |
|
@jldohmann I totally forgot to give you the PR for the IBM SE installation: #52661 |
|
Thank you @SNiemann15 ! Were you and @holgwolf able to sync about what to add to the IBM Z and LinuxONE section of the RN? I'm happy to add it to this PR if so! |
38fa000 to
c70ccc6
Compare
|
@jldohmann Thanks for the offer we have it included in this PR: #53464 |
c70ccc6 to
29b9041
Compare
|
@holgwolf thank you for the feedback, I've made some updates. Could you PTAL for the lgtm? @mike-nguyen could you also PTAL for QE ack? Thank you! |
|
/label peer-review-in-progress |
bscott-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small nits/suggestions. I locally built and verified the preview. LGTM, noting that the xref is invalid until the feature docs are merged.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
80ef8fe to
62f7868
Compare
|
/lgtm |
|
@holgwolf: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
62f7868 to
4241ac8
Compare
4241ac8 to
61400bf
Compare
Version(s): 4.12
Issue: https://issues.redhat.com/browse/OSDOCS-4137
Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-4118-RN/release_notes/ocp-4-12-release-notes.html#ocp-4-12-secure-execution-z-linux-one
QE review:
Additional information: build is failing on the xref to the feature doc #52661 but should be fine when that doc lands.