Skip to content

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Oct 14, 2022

Version(s): 4.12

Issue: https://issues.redhat.com/browse/OSDOCS-4137

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-4118-RN/release_notes/ocp-4-12-release-notes.html#ocp-4-12-secure-execution-z-linux-one

QE review:

  • QE has approved this change.

Additional information: build is failing on the xref to the feature doc #52661 but should be fine when that doc lands.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2022
@jldohmann jldohmann changed the title [enterprise-4.12] add SE RN entry [enterprise-4.12] OSDOCS-4137: add SE RN entry Oct 14, 2022
@jldohmann jldohmann added this to the Planned for 4.12 GA milestone Oct 14, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 14, 2022

🤖 Updated build preview is available at:
https://51732--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/5821

@jldohmann
Copy link
Contributor Author

@SNiemann15 Do you think the RN should have an entry for this in the IBM Z and LinuxONE section too? I realize the content may be duplicated, but I imagine some people jump straight to certain sections that are relevant to them.

@jldohmann
Copy link
Contributor Author

jldohmann commented Oct 26, 2022

d38ef56..38fa000 implement Silke feedback
38fa000..c70ccc6d14 add xref to feature doc
c70ccc6d14..29b9041523 implement QE feedback
29b9041523..80ef8fe8c7 implement peer review feedback pt1
80ef8fe8c7..62f7868756 implement peer review feedback pt2
62f7868756..4241ac8076 rebase
4241ac8076..61400bf fix xref

@SNiemann15
Copy link
Contributor

@jldohmann Thanks for bringing that up.
We will surely add SE info to the IBM Z and LinuxONE section too. I need to discuss with @holgwolf if we only want to add SE to the list of supported features or add more info.

@SNiemann15
Copy link
Contributor

@jldohmann I totally forgot to give you the PR for the IBM SE installation: #52661

@jldohmann
Copy link
Contributor Author

Thank you @SNiemann15 ! Were you and @holgwolf able to sync about what to add to the IBM Z and LinuxONE section of the RN? I'm happy to add it to this PR if so!

@SNiemann15
Copy link
Contributor

@jldohmann Thanks for the offer we have it included in this PR: #53464

@jldohmann
Copy link
Contributor Author

@holgwolf thank you for the feedback, I've made some updates. Could you PTAL for the lgtm? @mike-nguyen could you also PTAL for QE ack? Thank you!

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 19, 2022
@bscott-rh
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 19, 2022
Copy link
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nits/suggestions. I locally built and verified the preview. LGTM, noting that the xref is invalid until the feature docs are merged.

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 19, 2022
@jldohmann jldohmann force-pushed the OSDOCS-4118-RN branch 2 times, most recently from 80ef8fe to 62f7868 Compare December 19, 2022 19:34
@holgwolf
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2022

@holgwolf: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann merged commit 323496c into openshift:enterprise-4.12 Jan 3, 2023
@jldohmann jldohmann deleted the OSDOCS-4118-RN branch January 3, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants