Skip to content

Conversation

@mjpytlak
Copy link
Contributor

@mjpytlak mjpytlak commented Nov 15, 2022

Version(s):
4.12

Issue:
This PR addresses ocpbugs#2892.

Link to docs preview:
Known issues (second bulleted issue)

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2022
@mjpytlak mjpytlak added this to the Planned for 4.12 GA milestone Nov 15, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 15, 2022

🤖 Updated build preview is available at:
https://52820--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4710

@mjpytlak
Copy link
Contributor Author

@jeffnowicki this is ready for SME review. PTAL. Thank you.

@jeffnowicki
Copy link

@mjpytlak review comments... (not via PR review process... but hopefully these make sense... I sent screenshots and explanation in slack DM to you as well).

change 1:
$ oc ibmcloud is lb to $ ibmcloud is lb

change 2:
Verify that the traffic through to (Optional step) Run these commands from a new machine (IBM Cloud VSI) provisioned on the same subnet as one of the failed machines. The machine should also have the same security groups applied to it. Verify that the traffic through

@mjpytlak
Copy link
Contributor Author

review comments... (not via PR review process... but hopefully these make sense... I sent screenshots and explanation in slack DM to you as well).

Thanks @jeffnowicki. Made sense. PTAL.

@mjpytlak
Copy link
Contributor Author

@MayXuQQ Ready for QE review. PTAL. Thanks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get the cluster region
$oc get machines -n openshift-machine-api
...
set the target to the cluster
$ibmcloud target -g <cluster_ID> -r <cluster_region>

Copy link

@jeffnowicki jeffnowicki Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MayXuQQ I'd prefer to simplify your suggestion and state: "Before executing the following command, ensure you are logged into the IBM Cloud account for your cluster and target the correct region for your cluster." I think it's reasonable for the user to know how to log into ibmcloud and target the correct region (no need to give actual commands).

@mjpytlak Please insert the above sentence as follows:

Before executing the following command, ensure you are logged into the IBM Cloud account for your cluster and target the correct region for your cluster. Verify that the internal ALB status is active by running the following command:

@mjpytlak mjpytlak force-pushed the ocpbugs-2892 branch 2 times, most recently from f226a52 to 141258f Compare December 5, 2022 15:51
@MayXuQQ
Copy link

MayXuQQ commented Dec 5, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 5, 2022
@MayXuQQ
Copy link

MayXuQQ commented Dec 5, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fail to verify this step now, and what is expected output ?

Copy link

@MayXuQQ MayXuQQ Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffnowicki need much change before checking the traffic ? how about add doc to the
https://github.com/openshift/installer/tree/master/docs/user
and simplify the know issue doc ?

@MayXuQQ
Copy link

MayXuQQ commented Dec 6, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@jeffnowicki
Copy link

/lgtm

Nice work @mjpytlak

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

@jeffnowicki: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Nice work @mjpytlak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak mjpytlak added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 6, 2022
@jeana-redhat jeana-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 6, 2022
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a few formatting considerations for ya

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line break might make this easier to parse, and suggest moving the link to the end (as with the previous bulleted item) so users don't misinterpret that link as the end of the bullet.

Suggested change
* Intermittently, an IBM Cloud VPC cluster might fail to install because some worker machines do not start. Rather, these worker machines remain in the `Provisioned` phase. There is a workaround for this issue. From the host where you performed the initial installation, delete the failed machines and run the installation program again. (link:https://issues.redhat.com/browse/OCPBUGS-1327[*OCPBUGS#1327*])
* Intermittently, an IBM Cloud VPC cluster might fail to install because some worker machines do not start. Rather, these worker machines remain in the `Provisioned` phase.
+
There is a workaround for this issue. From the host where you performed the initial installation, delete the failed machines and run the installation program again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Agreed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+
(link:https://issues.redhat.com/browse/OCPBUGS-1327[*OCPBUGS#1327*])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. All set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does kubeconfig need some formatting? (asking because I don't know 🙂)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it does; indeed it does. Nice catch.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 6, 2022
@mjpytlak mjpytlak merged commit 5134d33 into openshift:enterprise-4.12 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants