Skip to content

Conversation

@pfeifferj
Copy link
Member

@pfeifferj pfeifferj commented Feb 22, 2023

Version(s):

>= enterprise-4.8

I will open separate PRs for enterprise-{4.8, 4.9, 4.10, 4.11, 4.12, 4.13}

Issue:

fixes #41971

Link to docs preview:

Forwarding logs using the syslog protocol

QE review:

  • QE has approved this change.

Additional information:

Followed same convention as Sample log forwarding outputs and pipelines

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 22, 2023

🤖 Updated build preview is available at:
https://56292--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/9680

@pfeifferj pfeifferj marked this pull request as ready for review February 22, 2023 14:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@pfeifferj pfeifferj changed the title Draft: [GH#41971] include syslog inputs [GH#41971] include syslog inputs Feb 22, 2023
@kalexand-rh kalexand-rh requested a review from libander February 23, 2023 14:00
Copy link
Contributor

@libander libander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@libander
Copy link
Contributor

@kabirbhartiRH / @anpingli / @QiaolingTang - LGTM please.

@pfeifferj pfeifferj closed this by deleting the head repository Feb 23, 2023
@pfeifferj pfeifferj reopened this Feb 23, 2023
@pfeifferj
Copy link
Member Author

can we merge the PR? :)

@libander
Copy link
Contributor

libander commented Mar 6, 2023

@pfeifferj - needs a /lgtm from @kabirbhartiRH to merge, requested one.

@kabirbhartiRH
Copy link

can we merge the PR? :)

@pfeifferj I still don't see the respective change suggested above. Could you check once.

@pfeifferj
Copy link
Member Author

weird, I fixed it on my fork but the PR doesn't seem to sync

@pfeifferj
Copy link
Member Author

I opened a new PR since this PR won't sync with my fork .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enterprise-4.8] Issue in file logging/cluster-logging-external.adoc

4 participants