-
Notifications
You must be signed in to change notification settings - Fork 1.8k
WIP OADP-2130: Updating OADP documentation #61927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@anarnold97: This pull request references OADP-2130 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/19425 |
|
testing locally but some errors only showing in Travis CI - Pull Request check |
|
Reading https://61927--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html I felt it could be renamed to Prerequisites (or something like that). I am afraid users may think there is OADP and OADP operator the way the titles are written today This part https://61927--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/features-and-plugins/oadp-features-plugins.html (the whole OADP features and plugins higher section) I think would be better after installing and before configuring (we present the plugins that will be used prior to configuring them) |
|
| |`kubevirt` |Backs up and restores OpenShift Virtualization resources. ^[2]^ |Object store | ||
|
|
||
| |`csi` |Backs up and restores volumes with CSI snapshots. ^[3]^ |Cloud storage that supports CSI snapshots | ||
| |=== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your call to include in this review or update.. 1.2.0 added the vsm plugin. Ah found jira OADP-2205
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: vsm is 1.2.0 only, and unfortunately will most likely be ripped out in 1.3.0. So perhaps just throw an asterisk on it :)
| * `azure` (Microsoft Azure) | ||
| * `openshift` (OpenShift Velero plugin) | ||
| * `csi` (Container Storage Interface) | ||
| * `kubevirt` (KubeVirt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubevirt should be removed, it's not a native velero plugin. It's openshift only
|
couple nits, but overall a really nice improvement. Thank you @anarnold97 !! |
|
|
||
| toc::[] | ||
|
|
||
| You restore application backups by creating a `Restore` custom resource (CR). See xref:../../../backup_and_restore/application_backup_and_restore/backing_up_and_restoring/restoring-applications.adoc#oadp-creating-restore-cr_restoring-applications[Creating a Restore CR]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this a new section
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |


Version(s):
Issue:
Link to docs preview:
QE review:
Additional information: