Skip to content

Conversation

@anarnold97
Copy link
Contributor

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 29, 2023

@anarnold97: This pull request references OADP-2130 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 29, 2023

🤖 Updated build preview is available at:
https://61927--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/19425

@anarnold97
Copy link
Contributor Author

testing locally but some errors only showing in Travis CI - Pull Request check

@mateusoliveira43
Copy link

Reading https://61927--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html I felt it could be renamed to Prerequisites (or something like that). I am afraid users may think there is OADP and OADP operator the way the titles are written today

This part https://61927--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/features-and-plugins/oadp-features-plugins.html (the whole OADP features and plugins higher section) I think would be better after installing and before configuring (we present the plugins that will be used prior to configuring them)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 7, 2023

Reading https://61927--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html I felt it could be renamed to Prerequisites (or something like that). I am afraid users may think there is OADP and OADP operator the way the titles are written today

This part https://61927--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/features-and-plugins/oadp-features-plugins.html (the whole OADP features and plugins higher section) I think would be better after installing and before configuring (we present the plugins that will be used prior to configuring them)

image

image

|`kubevirt` |Backs up and restores OpenShift Virtualization resources. ^[2]^ |Object store

|`csi` |Backs up and restores volumes with CSI snapshots. ^[3]^ |Cloud storage that supports CSI snapshots
|===

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call to include in this review or update.. 1.2.0 added the vsm plugin. Ah found jira OADP-2205

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: vsm is 1.2.0 only, and unfortunately will most likely be ripped out in 1.3.0. So perhaps just throw an asterisk on it :)

* `azure` (Microsoft Azure)
* `openshift` (OpenShift Velero plugin)
* `csi` (Container Storage Interface)
* `kubevirt` (KubeVirt)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubevirt should be removed, it's not a native velero plugin. It's openshift only

@weshayutin
Copy link

couple nits, but overall a really nice improvement. Thank you @anarnold97 !!
KUDOS!!


toc::[]

You restore application backups by creating a `Restore` custom resource (CR). See xref:../../../backup_and_restore/application_backup_and_restore/backing_up_and_restoring/restoring-applications.adoc#oadp-creating-restore-cr_restoring-applications[Creating a Restore CR].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this a new section

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants