Skip to content

Conversation

@HagayVider1
Copy link
Contributor

@HagayVider1 HagayVider1 commented Aug 17, 2023

OSDOCS# : OADP-2155

Version(s): OADP 1.2.1

Issue: https://issues.redhat.com/browse/OADP-2155

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2023

@HagayVider1: This pull request references OADP-2155 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2023

@HagayVider1: This pull request references OADP-2155 which is a valid jira issue.

In response to this:

OSDOCS# : OADP-2155

Version(s): OADP 1.2.1

Issue: https://issues.redhat.com/browse/OADP-2155

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2023

@HagayVider1: This pull request references OADP-2155 which is a valid jira issue.

In response to this:

OSDOCS# : OADP-2155

Version(s): OADP 1.2.1

Issue: https://issues.redhat.com/browse/OADP-2155

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anarnold97
Copy link
Contributor

@HagayVider1 - I think we need to include the modules from this doc as well https://docs.openshift.com/rosa/rosa_getting_started/rosa-sts-getting-started-workflow.html

Also, you have a build error:

ERROR (backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.adoc): "xref:../../../backup_and_restore/application_backup_and_restore/installing/installing-oadp-rosa.adoc#installing-oadp-rosa[Red Hat OADP Service for AWS]" appears to try to reference a file not included in the "openshift-enterprise" distro

Please, let us discuss this on Tuesday and walk through it.

Do NOT worry ... It is only a broken link.

@anarnold97
Copy link
Contributor

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Aug 17, 2023
This process has the following stages:

. Prepare AWS credentials
. Install OADP Operator and provide it with the AIM role
Copy link
Contributor

@anarnold97 anarnold97 Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


toc::[]

You can employ OpenShift API for Data Protection (OADP) with Red Hat OpenShift Service on AWS (ROSA) clusters to backup and restore application data. Before installing OADP, you must set up role and policy credentials for OADP so that it can use the AWS API.
Copy link
Contributor

@anarnold97 anarnold97 Aug 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can employ OpenShift API for Data Protection (OADP) with Red Hat OpenShift Service on AWS (ROSA) clusters to backup and restore application data. Before installing OADP, you must set up role and policy credentials for OADP so that it can use the AWS API.
You can employ OpenShift API for Data Protection (OADP) with Red Hat OpenShift Service on AWS (ROSA) clusters to backup and restore application data. For more information about xref:../../../rosa/rosa_architecture/rosa-understanding.html[Understanding ROSA].
Before installing OADP, you must set up role and policy credentials for OADP so that it can use the AWS API.

You will need to check the xref link. But what do you think?

@anarnold97
Copy link
Contributor

@HagayVider1 - do not forget to speak to Frances about this OSDOCS-6598 ticket?

@anarnold97
Copy link
Contributor

@HagayVider1

So the first build error:

ERROR (backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.adoc): "xref:../../../backup_and_restore/application_backup_and_restore/installing/installing-oadp-rosa.adoc#installing-oadp-rosa[Red Hat OADP Service for AWS]" appears to try to reference a file not included in the "openshift-enterprise" distro

The command "python3 build.py --distro openshift-enterprise --product "OpenShift Container Platform" --version 4.14 --no-upstream-fetch && python3 makeBuild.py" exited with 255.

This error is returned as you have not included - installing-oadp-rosa.adoc in _topic_map.yml so this file is not included in the build, which is why the link breaks:

So in the relevant section of the _topic_map.yml enter something like:

 - Name: Installing and configuring OADP with ROSA 
   File: installing-oadp-rosa 

Be careful with the indentation.

@anarnold97
Copy link
Contributor

@HagayVider1 - Once you have fixed this error, I think you will find you have other build errors

Let us go through them on Tuesday

@kalexand-rh
Copy link
Contributor

I've opened the enterprise-4.15 branch. Please review your PR and update the applicable versions to also cover 4.15 if you expect that the changes in this PR will be valid in that branch.

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2024

@HagayVider1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 46497f6 link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 10, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. OADP Label for all OADP PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants