-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-7789: Migration of Mobb.Ninja content "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" #64916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
062b933 to
c9d3d82
Compare
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26419 |
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b85e704 to
8413c2d
Compare
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments
2453c01 to
b06f8eb
Compare
|
Hi @michaelryanmcneill - Can you please review this PR? Thanks so much! |
|
|
||
| * The link:https://aws.amazon.com/cli/[AWS CLI] | ||
| * The link:https://stedolan.github.io/jq/[`jq` command] | ||
| * A ROSA cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be another Prerequisite that a user with group cluster-admins created.
I tried, dedicated-admin cannot work
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc create namespace amazon-cloudwatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a pre-login step with cluster-admin to run oc commands
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ wget -O $SCRATCH_DIR/cloud-watch.yaml https://mobb.ninja/docs/rosa/metrics-to-cloudwatch-agent/cloud-watch.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wget only works for linux, how about mac and Windows?
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ aws iam create-access-key \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ aws iam create-access-key \ | |
| $ aws iam create-access-key --output json\ |
Better to add --output json in case some customers have set output format of aws to txt or table on local. Otherwise below commands cannot work.
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ wget -O $SCRATCH_DIR/dashboard.json https://raw.githubusercontent.com/rh-mobb/documentation/main/content/docs/rosa/metrics-to-cloudwatch-agent/dashboard.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The raw file cannot find with 404. Please make sure it can be reached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| . Go to the link:https://us-east-2.console.aws.amazon.com/cloudwatch[CloudWatch section] of the AWS Console. | ||
|
|
||
| . Create a dashboard and name it "Kubernetes API Server". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Create a dashboard and name it "Kubernetes API Server". | |
| . Create a dashboard and name it "kube-api". |
Kubernetes API Server is not a valid dashboard name on AWS. It has validation with Valid characters in dashboard names include "0-9A-Za-z-_".
And below picture show kube-api as the dashboard name
adc1f40 to
145da7d
Compare
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5292551 to
a29d0a1
Compare
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a29d0a1 to
6ff4a6d
Compare
6ff4a6d to
5b38f67
Compare
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jneczypor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation
Version(s):
4.14+
Issue:
https://issues.redhat.com/browse/OSDOCS-7789
Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics
QE review:
Additional information: