Skip to content

Conversation

@jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Sep 19, 2023

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 20, 2023

🤖 Updated build preview is available at:
https://64916--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26419

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/rosa_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2023
@jneczypor
Copy link
Contributor Author

Hi @michaelryanmcneill - Can you please review this PR? Thanks so much!


* The link:https://aws.amazon.com/cli/[AWS CLI]
* The link:https://stedolan.github.io/jq/[`jq` command]
* A ROSA cluster

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be another Prerequisite that a user with group cluster-admins created.
I tried, dedicated-admin cannot work

+
[source,terminal]
----
$ oc create namespace amazon-cloudwatch

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a pre-login step with cluster-admin to run oc commands

+
[source,terminal]
----
$ wget -O $SCRATCH_DIR/cloud-watch.yaml https://mobb.ninja/docs/rosa/metrics-to-cloudwatch-agent/cloud-watch.yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wget only works for linux, how about mac and Windows?

+
[source,terminal]
----
$ aws iam create-access-key \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ aws iam create-access-key \
$ aws iam create-access-key --output json\

Better to add --output json in case some customers have set output format of aws to txt or table on local. Otherwise below commands cannot work.

+
[source,terminal]
----
$ wget -O $SCRATCH_DIR/dashboard.json https://raw.githubusercontent.com/rh-mobb/documentation/main/content/docs/rosa/metrics-to-cloudwatch-agent/dashboard.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raw file cannot find with 404. Please make sure it can be reached.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


. Go to the link:https://us-east-2.console.aws.amazon.com/cloudwatch[CloudWatch section] of the AWS Console.

. Create a dashboard and name it "Kubernetes API Server".
Copy link

@xueli181114 xueli181114 Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Create a dashboard and name it "Kubernetes API Server".
. Create a dashboard and name it "kube-api".

Kubernetes API Server is not a valid dashboard name on AWS. It has validation with Valid characters in dashboard names include "0-9A-Za-z-_".
And below picture show kube-api as the dashboard name

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/rosa_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2023

@jneczypor: This pull request references OSDOCS-7789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7789: Migrate "Using the AWS CloudWatch agent to publish metrics to CloudWatch in ROSA" to ROSA product documentation

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-7789

Link to docs preview:
https://64916--docspreview.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/rosa-mobb-aws-cloudwatch-publish-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2024

@jneczypor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 5b38f67 link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 9, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants