Skip to content

OSDOCS#7103: 4.13 backport of Conditional Update Guidance#65182

Merged
mburke5678 merged 1 commit intoopenshift:enterprise-4.13from
skopacz1:OSDOCS-7103_4.13
Sep 25, 2023
Merged

OSDOCS#7103: 4.13 backport of Conditional Update Guidance#65182
mburke5678 merged 1 commit intoopenshift:enterprise-4.13from
skopacz1:OSDOCS-7103_4.13

Conversation

@skopacz1
Copy link
Contributor

@skopacz1 skopacz1 commented Sep 25, 2023 •
edited
Loading

OSDOCS-7103

Version: 4.13

This is the 4.13 backport of #64646

QE review:

  • QE has approved this change. (QE has approved original PR, no changes to 4.13 backport)

Preview: Assessing the risk of conditional updates

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2023 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-7103 which is a valid jira issue.

Details

In response to this:

OSDOCS-7103

Version: 4.13

This is the 4.13 backport of #64646

QE review:

  • QE has approved this change. (QE has approved original PR, no changes to 4.13 backport)

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 25, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://65182--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/25807

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2023 •
edited by openshift-ci bot
Loading

@skopacz1: This pull request references OSDOCS-7103 which is a valid jira issue.

Details

In response to this:

OSDOCS-7103

Version: 4.13

This is the 4.13 backport of #64646

QE review:

  • QE has approved this change. (QE has approved original PR, no changes to 4.13 backport)

Preview: Assessing the risk of conditional updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skopacz1 skopacz1 changed the title OSDOCS-7103: 4.13 backport of Conditional Update Guidance OSDOCS#7103: 4.13 backport of Conditional Update Guidance Sep 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2023

@skopacz1: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

OSDOCS-7103

Version: 4.13

This is the 4.13 backport of #64646

QE review:

  • QE has approved this change. (QE has approved original PR, no changes to 4.13 backport)

Preview: Assessing the risk of conditional updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2023
@skopacz1
Copy link
Contributor Author

skopacz1 commented Sep 25, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 25, 2023
@cbippley
Copy link
Contributor

cbippley commented Sep 25, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 25, 2023
cbippley
cbippley reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As I'm still in training please wait for @opayne1 to review before requesting a merge review. Thanks!

@cbippley
Copy link
Contributor

cbippley commented Sep 25, 2023

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 25, 2023
@opayne1 opayne1 added this to the Continuous Release milestone Sep 25, 2023
opayne1
opayne1 reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment for you to consider. If you decide to change it you might want to update the other PR too.

modules/update-preparing-conditional.adoc Outdated
//
// * updating/updating-cluster-prepare.adoc

:_content-type: PROCEDURE
Copy link
Contributor

@opayne1 opayne1 Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious as to how this is considered a procedure module? It almost seems like a concept module to me. I was looking at the mod doc guidelines https://redhat-documentation.github.io/modular-docs/#con-creating-procedure-modules_writing-mod-docs

Copy link
Contributor Author

@skopacz1 skopacz1 Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in fact a conceptual module and not a procedural one, thanks for catching this! Now to fix this error in main as well 🤦‍♂️

@skopacz1
Copy link
Contributor Author

skopacz1 commented Sep 25, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 25, 2023
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 25, 2023
@mburke5678 mburke5678 merged commit 006c518 into openshift:enterprise-4.13 Sep 25, 2023
@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 25, 2023
@skopacz1 skopacz1 deleted the OSDOCS-7103_4.13 branch October 31, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opayne1 opayne1 opayne1 left review comments

+1 more reviewer

@cbippley cbippley cbippley left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@skopacz1 @openshift-ci-robot @ocpdocs-previewbot @cbippley @opayne1 @mburke5678