Skip to content

Dual stack configuration release note#66996

Merged
kcarmichael08 merged 1 commit intoopenshift:enterprise-4.14from
jmanthei:OSDOCS-4938-rn-rety
Oct 27, 2023
Merged

Dual stack configuration release note#66996
kcarmichael08 merged 1 commit intoopenshift:enterprise-4.14from
jmanthei:OSDOCS-4938-rn-rety

Conversation

@jmanthei
Copy link
Contributor

@jmanthei jmanthei commented Oct 26, 2023

Version(s):

Issue: https://issues.redhat.com/browse/OSDOCS-4938

Link to docs preview: https://66996--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2023
@jmanthei
Copy link
Contributor Author

@weliang1 related to the doc update, just a condensed version. Please QE check
@dougbtv if you wanna see what I did, thank you so much for the quick turnaround

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 26, 2023

🤖 Updated build preview is available at:
https://66996--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/30717

@weliang1
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@kalexand-rh kalexand-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 27, 2023
@lahinson
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 27, 2023
@lahinson
Copy link
Contributor

Just for reference, I'm adding the link to the doc preview: https://66996--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes

@jmanthei
Copy link
Contributor Author

/label merge-review-needed

@jmanthei
Copy link
Contributor Author

Just for reference, I'm adding the link to the doc preview: https://66996--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes

Thank you @lahinson

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 27, 2023
@lahinson
Copy link
Contributor

/remove-label merge-review-needed

Removing this for a moment, as I'm still completing peer review :)

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 27, 2023
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmanthei Nice work! I added a couple of suggestions, but overall LGTM.

[id="ocp-4-14-dual-stack-configuration"]
==== Dual stack configuration for multiple IP addresses

In previous releases of Whereabouts IPAM CNI, only one IP address could be assigned per network interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In previous releases of Whereabouts IPAM CNI, only one IP address could be assigned per network interface.
In previous releases of the Whereabouts IPAM CNI plugin, only one IP address could be assigned per network interface.

Adding a little more context here for any readers who might not immediately know that Whereabouts is an IPAM CNI plugin.


In previous releases of Whereabouts IPAM CNI, only one IP address could be assigned per network interface.

Now, Whereabouts IPAM CNI supports assignment of an arbitrary number of IP addresses in order to support dual-stack IPv4/IPv6 functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now, Whereabouts IPAM CNI supports assignment of an arbitrary number of IP addresses in order to support dual-stack IPv4/IPv6 functionality.
Now, Whereabouts supports the assignment of an arbitrary number of IP addresses to support dual-stack IPv4/IPv6 functionality.
  • Since the first sentence states what Whereabouts is, I think we can get away with referring to it as simply "Whereabouts" in the second sentence.
  • IBM Style advises using "to" instead of "in order to" in most cases. See the Word Usage page and ctrl+F to find the entry for "in order to".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make it better? Thank you.

@lahinson
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 27, 2023
@jmanthei jmanthei force-pushed the OSDOCS-4938-rn-rety branch from 8d2b00e to 0e12c00 Compare October 27, 2023 17:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

New changes are detected. LGTM label has been removed.

@jmanthei jmanthei force-pushed the OSDOCS-4938-rn-rety branch from 0e12c00 to d4e975d Compare October 27, 2023 17:04
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.14 labels Oct 27, 2023
@kcarmichael08 kcarmichael08 added this to the Planned for 4.14 GA milestone Oct 27, 2023
@kcarmichael08 kcarmichael08 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 27, 2023
@kcarmichael08 kcarmichael08 merged commit 885d998 into openshift:enterprise-4.14 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants