Skip to content

ROX#18370: add pull secret definitions and make show up on kubernetes instructions #73647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcarmichael08 merged 1 commit into from
Mar 26, 2024
Merged

ROX#18370: add pull secret definitions and make show up on kubernetes instructions #73647

kcarmichael08 merged 1 commit into from
Mar 26, 2024

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Mar 22, 2024 •
edited
Loading

Version(s):
4.3+

Issue

Links to docs previews:

QE review:

  • QE has approved this change.

Additional information:

Due to incorrect conditionals, and a mistake, pull secret info not showing up on Helm installation method for secured clusters for Kubernetes systems

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 22, 2024 •
edited
Loading

🤖 Updated build preview is available at:
https://73647--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37988

@kcarmichael08 kcarmichael08 force-pushed the ROX-18370-update-secured-cluster branch from d303f0f to 2a0e220 Compare March 22, 2024 20:30
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2024
@kcarmichael08 kcarmichael08 added peer-review-needed Signifies that the peer review team needs to review this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.3 rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 labels Mar 25, 2024
@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Mar 25, 2024

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2024
GroceryBoyJr
GroceryBoyJr reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Mar 25, 2024

/remove-label peer-review-in-progress
/label peer-review-done
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 25, 2024
@kcarmichael08 kcarmichael08 merged commit a6003ed into openshift:rhacs-docs Mar 26, 2024
@kcarmichael08 kcarmichael08 deleted the ROX-18370-update-secured-cluster branch March 26, 2024 18:05
@kcarmichael08
Copy link
Contributor Author

kcarmichael08 commented Mar 26, 2024

/cherrypick rhacs-docs-4.3

@kcarmichael08
Copy link
Contributor Author

kcarmichael08 commented Mar 26, 2024

/cherrypick rhacs-docs-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 26, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 26, 2024

@kcarmichael08: new pull request created: #73759

Details

In response to this:

/cherrypick rhacs-docs-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 26, 2024

@kcarmichael08: new pull request created: #73760

Details

In response to this:

/cherrypick rhacs-docs-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@kurlov kurlov kurlov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kcarmichael08 @ocpdocs-previewbot @GroceryBoyJr @openshift-cherrypick-robot @kurlov